Skip to content

RN: Implement sendAccessibilityEvent in RN Renderer that proxies between Fabric/non-Fabric #20554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 27, 2021
Merged

RN: Implement sendAccessibilityEvent in RN Renderer that proxies between Fabric/non-Fabric #20554

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b29a6d7
RN: Implement `sendAccessibilityEvent` on HostComponent
JoshuaGross Jan 6, 2021
4871f0e
Move methods out of HostComponent
JoshuaGross Jan 7, 2021
502204a
Properly type dispatchCommand and sendAccessibilityEvent handle arg
JoshuaGross Jan 7, 2021
c2e2609
Implement Fabric side of sendAccessibilityEvent
JoshuaGross Jan 19, 2021
3a15531
Add tests: 1. Fabric->Fabric, 2. Paper->Fabric, 3. Fabric->Paper, 4. …
JoshuaGross Jan 27, 2021
f35baaf
Fix typo: ReactFaricEventTouch -> ReactFabricEventTouch
JoshuaGross Jan 27, 2021
bb89265
fix flow types
JoshuaGross Jan 27, 2021
27e5f63
prettier
JoshuaGross Jan 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/react-native-renderer/src/ReactFabricHostConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,16 @@ class ReactFabricHostComponent {

return;
}

sendAccessibilityEvent(eventType: string) {
if (__DEV__) {
console.warn(
'Warning: sendAccessibilityEvent is not currently supported in Fabric (coming soon)',
);
}

return;
}
}

// eslint-disable-next-line no-unused-expressions
Expand Down
9 changes: 9 additions & 0 deletions packages/react-native-renderer/src/ReactNativeFiberHostComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import type {Instance} from './ReactNativeHostConfig';
import {
TextInputState,
UIManager,
DeprecatedAccessibilityInfo,
} from 'react-native/Libraries/ReactPrivate/ReactNativePrivateInterface';

import {create} from './ReactNativeAttributePayload';
Expand Down Expand Up @@ -124,6 +125,14 @@ class ReactNativeFiberHostComponent {
);
}
}

sendAccessibilityEvent(eventType: string) {
if (eventType === 'focus') {
DeprecatedAccessibilityInfo.setAccessibilityFocus(this._nativeTag);
} else {
Copy link
Member

@elicwhite elicwhite Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Fabric is not going to throw on invalid strings from JS, we probably want that behavior consistent on paper. Probably just no-op. Enforcement can come from the types

throw Error('eventType ' + eventType + ' is not currently supported.');
}
}
}

// eslint-disable-next-line no-unused-expressions
Expand Down