Skip to content

Add modern event system flag + rename legacy plugin module #18073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2020
Merged

Add modern event system flag + rename legacy plugin module #18073

merged 1 commit into from
Feb 19, 2020

Conversation

@trueadm
Copy link
Contributor

@trueadm trueadm commented Feb 19, 2020 •
edited
Loading

This PR does four things:

  • Cleans up ReactBrowserEventEmitter-test.internal.js a bit
  • Re-labels listenToEvent to legacyListenToEvent
  • Renames the module DOMEventPluginSystem to DOMLegacyEventPluginSystem
  • Adds the enableModernEventSystem flag

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 19, 2020
@sizebot
Copy link

sizebot commented Feb 19, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against e408749

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 19, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@sizebot
Copy link

sizebot commented Feb 19, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against e408749

threepointone
threepointone approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a nit. Also, you're not using the new feature flag anywhere yet, so maybe it shouldn't be in this PR? Your call.

@trueadm trueadm merged commit 4912ba3 into facebook:master Feb 19, 2020
@trueadm trueadm deleted the roots-phase1 branch February 19, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaearon gaearon Awaiting requested review from gaearon

1 more reviewer

@threepointone threepointone threepointone approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trueadm @sizebot @threepointone @facebook-github-bot