Skip to content

Fix <embed> not triggering onLoad #15614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2019
Merged

Fix <embed> not triggering onLoad #15614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71a6a91
make <embed> trigger onLoad
cherniavskii May 10, 2019
8858f4e
add unit test
cherniavskii May 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions packages/react-dom/src/__tests__/ReactDOMEventListener-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,4 +446,31 @@ describe('ReactDOMEventListener', () => {
document.body.removeChild(container);
}
});

it('should dispatch load for embed elements', () => {
const container = document.createElement('div');
document.body.appendChild(container);

try {
const ref = React.createRef();
const handleLoad = jest.fn();

ReactDOM.render(
<div>
<embed ref={ref} onLoad={handleLoad} />
</div>,
container,
);

ref.current.dispatchEvent(
new ProgressEvent('load', {
bubbles: false,
}),
);

expect(handleLoad).toHaveBeenCalledTimes(1);
} finally {
document.body.removeChild(container);
}
});
});
2 changes: 2 additions & 0 deletions packages/react-dom/src/client/ReactDOMComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,7 @@ export function setInitialProperties(
switch (tag) {
case 'iframe':
case 'object':
case 'embed':
trapBubbledEvent(TOP_LOAD, domElement);
props = rawProps;
break;
Expand Down Expand Up @@ -916,6 +917,7 @@ export function diffHydratedProperties(
switch (tag) {
case 'iframe':
case 'object':
case 'embed':
trapBubbledEvent(TOP_LOAD, domElement);
break;
case 'video':
Expand Down