Mark Profiler API as stable #15172
Merged
Mark Profiler API as stable #15172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ |
|
Per my comment on Twitter the other day, it would be nice to have metrics for commit times too (especially if sync |
|
Awesome! Did this land in 16.8.5? |
|
No, 16.9 😄 |
|
Oh, nice. Good to know. Thanks! |
Merged
This was referenced Aug 17, 2019
This was referenced Aug 24, 2019
This was referenced Mar 10, 2020
This was referenced Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ProfilerRFC (reactjs/rfcs#51) is 10 months old and API hasn't changed in months. It seems like that we'll want to add a new API forSuspensemetrics, but as a new prop that should not impact the existingonRenderprop.Maybe it's time to mark this API as stable? Opening for discussion purposes.
(If this lands, I will update and close out the RFC.)