Simplify wording of key warning #14503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think "array or iterator" is adding anything, and it may well be confusing, especially since this is one of the first and most common warnings that devs see.
Contributor
|
I am not a fan of this change. Since there are no "lists" in javascript. Searching for "JavaScript list" on Google will not provide the same results as "JavaScript iterator" or array. |
Collaborator
|
If we change this here's our chance to also clarify "unique" only applies to siblings and not globally. |
Collaborator
Author
|
Hmm I kinda liked the simplicity. |
bvaughn
approved these changes
Dec 31, 2018
Contributor
bvaughn
left a comment
bvaughn
left a comment
There was a problem hiding this comment.
I like the change of "an array or iterator" to "a list" 👍
I don't have a strong feeling about Dan's follow up suggestion.
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
I don't think "array or iterator" is adding anything, and it may well be confusing, especially since this is one of the first and most common warnings that devs see.
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
I don't think "array or iterator" is adding anything, and it may well be confusing, especially since this is one of the first and most common warnings that devs see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think "array or iterator" is adding anything, and it may well be confusing, especially since this is one of the first and most common warnings that devs see.