Enable hooks by default for FB React Native renderer

[bvaughn]

No description provided.

[sebmarkbage]

The rest of these, are they still relevant to be dynamic or can we just turn them on or off?

[yungsters]

Only debugRenderPhaseSideEffects is currently dynamically configured internally.

We always set debugRenderPhaseSideEffectsForStrictMode to true.

[bvaughn]

Looks like debugRenderPhaseSideEffects is a dynamic value, debugRenderPhaseSideEffectsForStrictMode is being set to true in InitializeReactFeatureFlags, and nothing is changing the default value of warnAboutDeprecatedLifecycles.

[sizebot]

Details of bundled changes.

Comparing: a22880e...f7eaa2d

react-native-renderer

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
ReactNativeRenderer-dev.js	-0.0%	-0.0%	568.59 KB	568.38 KB	123.54 KB	123.49 KB	RN_FB_DEV
ReactNativeRenderer-prod.js	🔺+0.2%	-0.1%	238.83 KB	239.22 KB	42 KB	41.97 KB	RN_FB_PROD
ReactNativeRenderer-profiling.js	+0.2%	-0.1%	244.7 KB	245.09 KB	43.36 KB	43.34 KB	RN_FB_PROFILING
ReactNativeRenderer-dev.js	0.0%	-0.0%	568.29 KB	568.29 KB	123.46 KB	123.46 KB	RN_OSS_DEV
ReactFabric-dev.js	0.0%	-0.0%	559.1 KB	559.1 KB	121.1 KB	121.1 KB	RN_FB_DEV
ReactFabric-prod.js	0.0%	-0.0%	233.34 KB	233.34 KB	40.77 KB	40.77 KB	RN_FB_PROD
ReactFabric-dev.js	0.0%	-0.0%	559.13 KB	559.13 KB	121.12 KB	121.12 KB	RN_OSS_DEV

Generated by 🚫 dangerJS

[bvaughn]

I've pushed another commit to this branch that makes all but one of the flags (debugRenderPhaseSideEffects) static.

Here are the new flag values:

flag	previous	current
debugRenderPhaseSideEffects	(dynamic)	(dynamic)
debugRenderPhaseSideEffectsForStrictMode	true	true
disableInputAttributeSyncing	false	false
enableHooks	(dynamic)	true
replayFailedUnitOfWorkWithInvokeGuardedCallback	false	__DEV__
warnAboutDeprecatedLifecycles	true	true