-
Notifications
You must be signed in to change notification settings - Fork 49.9k
Improve DX when combining react-dom/profiling and schedule/tracking #13605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
889a8de
schedule/tracking (production bundle) should not cause react-dom (pro…
996eb69
Added blessed production+profiling entry point for schedule/tracking
16bef4c
Revert "schedule/tracking (production bundle) should not cause react-…
8bfc0bf
Add invariant when profiling renderer is used with non-profiling sche…
f006b54
Improved tracking+renderer profiling bundle mismatch error message
1168d34
Comment tweak
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
packages/react-reconciler/src/__tests__/ReactTracking-test.internal.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /** | ||
| * Copyright (c) Facebook, Inc. and its affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| * | ||
| * @emails react-core | ||
| * @jest-environment node | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| describe('ReactTracking', () => { | ||
| it('should error if profiling renderer and non-profiling schedule/tracking bundles are combined', () => { | ||
| jest.resetModules(); | ||
|
|
||
| const ReactFeatureFlags = require('shared/ReactFeatureFlags'); | ||
| ReactFeatureFlags.enableSchedulerTracking = false; | ||
|
|
||
| require('schedule/tracking'); | ||
|
|
||
| ReactFeatureFlags.enableSchedulerTracking = true; | ||
|
|
||
| expect(() => require('react-dom')).toThrow( | ||
| 'Learn more at http://fb.me/react-profiling', | ||
| ); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| 'use strict'; | ||
|
|
||
| if (process.env.NODE_ENV === 'production') { | ||
| module.exports = require('./cjs/schedule-tracking.profiling.min.js'); | ||
| } else { | ||
| module.exports = require('./cjs/schedule-tracking.development.js'); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,7 @@ | |
| "README.md", | ||
| "index.js", | ||
| "tracking.js", | ||
| "tracking-profiling.js", | ||
| "cjs/", | ||
| "umd/" | ||
| ] | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: does this line need to start with capital letter? Made reading the sentence a bit confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I can change the comment 😆