Skip to content

More helpful message when passing an element to createElement() #13131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 1, 2018
+25 −0
Merged

More helpful message when passing an element to createElement() #13131

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
85a4ccb
[#13130] Add a more helpful message when passing an element to create…
DCtheTall Jun 30, 2018
24a071f
better conditional flow
DCtheTall Jun 30, 2018
4bf86b0
update after review
DCtheTall Jul 5, 2018
eafc93c
move last condition inside last else clause
DCtheTall Jul 17, 2018
453455d
Added test case
DCtheTall Jul 18, 2018
7d26762
compare 25132typeof to REACT_ELEMENT_TYPE
DCtheTall Jul 18, 2018
97bbb11
Merge branch 'master' into fix-issue-13130
DCtheTall Jul 18, 2018
537925f
runs prettier
DCtheTall Jul 18, 2018
55bf68a
remove unrelated changes
DCtheTall Jul 18, 2018
095832e
Tweak the message
gaearon Aug 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react/src/ReactElementValidator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,10 @@ export function createElementWithValidation(type, props, children) {
typeString = 'array';
} else {
typeString = typeof type;
if (type && type.hasOwnProperty('$$typeof')) {
typeString = 'element';
Copy link
Collaborator

@gaearon gaearon Jul 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"React element" would be better here.

Also now that I think of it let's compare type.$$typeof === REACT_ELEMENT_TYPE explicitly. We don't actually "own" this convention. You can get REACT_ELEMENT_TYPE from existing ReactSymbols import in this file.

info = ' Did you accidentally export JSX instead of a component?';
}
}

warning(
Expand Down
5 changes: 5 additions & 0 deletions packages/react/src/__tests__/ReactElementValidator-test.internal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ describe('ReactElementValidator', () => {
React.createElement(true);
React.createElement({x: 17});
React.createElement({});
React.createElement(React.createElement('div'));
}).toWarnDev([
'Warning: React.createElement: type is invalid -- expected a string ' +
'(for built-in components) or a class/function (for composite ' +
Expand All @@ -255,6 +256,10 @@ describe('ReactElementValidator', () => {
'components) but got: object. You likely forgot to export your ' +
"component from the file it's defined in, or you might have mixed up " +
'default and named imports.',
'Warning: React.createElement: type is invalid -- expected a string ' +
'(for built-in components) or a class/function (for composite ' +
'components) but got: element. Did you accidentally export JSX ' +
'instead of a component?',
]);

// Should not log any additional warnings
Expand Down