Skip to content

Add missing single-word attributes to property warning list #10495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 21, 2017
Merged

Add missing single-word attributes to property warning list #10495

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64008e7
Add missing single-word attributes to property warning list
nhunzaker Aug 18, 2017
0ccbe71
Alphabetize svg and html configs in possible names
nhunzaker Aug 18, 2017
de06c4a
Add basic test coverage for known single word attributes
nhunzaker Aug 18, 2017
77861ec
Add note about including whitelist properites in `possibleStandardNames
nhunzaker Aug 18, 2017
37608e5
Also add attribute sync comment to possibleStandardNames
nhunzaker Aug 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2080,6 +2080,18 @@ describe('ReactDOMComponent', () => {
'Warning: Invalid prop `whatever` on <div> tag.',
);
});

it('warns on bad casing of known HTML attributes', function() {
spyOn(console, 'error');

var el = ReactTestUtils.renderIntoDocument(<div SiZe="30" />);

expect(el.getAttribute('size')).toBe('30');

expectDev(console.error.calls.argsFor(0)[0]).toContain(
'Warning: Invalid DOM property `SiZe`. Did you mean `size`?',
);
});
});

describe('Object stringification', function() {
Expand Down
Loading