Remove hidden functional shouldComponentUpdate API #10371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiebits
approved these changes
Aug 3, 2017
Collaborator
|
as long as tests pass? might need to be a feature flag |
Collaborator
Author
|
Passed locally but let's wait to be sure. |
Collaborator
|
I think the tests that relied on this has been disabled by @acdlite since they relied on the incremental optimization. When we enable those, we'll need this back. |
Collaborator
Author
|
We'll add behind a flag then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was added for internal testing and not meant to be part of 16 public API.
We can always re-add if we think we need it.