Skip to content

Conversation

@axyz
Copy link

@axyz axyz commented Nov 6, 2025

This was recently changed as part of the refactoring of 74562f4#diff-bcc5857af5fe29c6679b5afaf39db7eed5fc74a15ab118691ee8c13c5954b70eL75

this implicitly binds react-strict-dom to require at least react-native 0.82.

Is that intentional?

Is there a place where the minimum required version is explicitly listed?

In that case, then maybe was just forgotten to update the peer dependency here: https://github.com/facebook/react-strict-dom/blob/main/packages/react-strict-dom/package.json#L62

Feel free to close in case, and treat this PR as a small question with a code snippet

@axyz axyz requested a review from necolas as a code owner November 6, 2025 17:37
@meta-cla
Copy link

meta-cla bot commented Nov 6, 2025

Hi @axyz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla meta-cla bot added the cla signed label Nov 6, 2025
@meta-cla
Copy link

meta-cla bot commented Nov 6, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

2 similar comments
@meta-cla
Copy link

meta-cla bot commented Nov 6, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla
Copy link

meta-cla bot commented Nov 6, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@necolas
Copy link
Contributor

necolas commented Nov 7, 2025

Let's bump the peer dependency instead - there are a few other things that require 0.82 now

@axyz
Copy link
Author

axyz commented Nov 10, 2025

closed in favor of #421

@axyz axyz closed this Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants