Skip to content

ReactInstanceManager API Updates #9217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ReactInstanceManager API Updates #9217

wants to merge 1 commit into from

Conversation

@forrestbice
Copy link
Contributor

@forrestbice forrestbice commented Aug 4, 2016

Updating code example with updated method names...

onHostPause -> onPause
onHostResume -> onResume
onHostDestroy -> onDestroy

@forrestbice
ReactInstanceManager API Updates
3c2a1bc 
Updating example code with updated method names...

`onHostPause` -> `onPause`
`onHostResume` -> `onResume`
`onHostDestroy` -> `onDestroy`
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 4, 2016

By analyzing the blame information on this pull request, we identified @JoelMarcey and @mtunique to be potential reviewers.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 4, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@ghost
Copy link

ghost commented Aug 4, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2016
@javache
Copy link
Member

javache commented Aug 4, 2016

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Aug 4, 2016
@ghost
Copy link

ghost commented Aug 4, 2016

Thanks for importing.If you are an FB employee go to Phabricator to review internal test results.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2016
@ghost ghost closed this in 30677e7 Aug 4, 2016
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
@forrestbice
ReactInstanceManager API Updates
710766d 
Summary:
Updating code example with updated method names...

`onHostPause` -> `onPause`
`onHostResume` -> `onResume`
`onHostDestroy` -> `onDestroy`
Closes facebook#9217

Differential Revision: D3671267

Pulled By: javache

fbshipit-source-id: 007a2b0909fee4495a98c141bd6ac3a564b50c17
@forrestbice forrestbice deleted the forrestbice-patch-1 branch April 6, 2021 19:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@forrestbice @facebook-github-bot @javache