Skip to content

A fix for npmlog error #8994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

A fix for npmlog error #8994

wants to merge 1 commit into from

Conversation

@GevaZeichner
Copy link
Contributor

@GevaZeichner GevaZeichner commented Jul 24, 2016

Added a fix to the GettingStarted guide, for when npmlog module isn't found.
Solution copied from: tj/n#101 (comment)

@ghost
Copy link

ghost commented Jul 24, 2016

By analyzing the blame information on this pull request, we identified @JoelMarcey and @lacker to be potential reviewers.

@ghost
Copy link

ghost commented Jul 24, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 24, 2016
@ghost
Copy link

ghost commented Jul 24, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@JoelMarcey
Copy link

JoelMarcey commented Jul 25, 2016

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jul 25, 2016
@ghost
Copy link

ghost commented Jul 25, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2016
@ghost ghost closed this in feb2825 Jul 25, 2016
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
@GevaZeichner
A fix for npmlog error
c1505fe 
Summary:
Added a fix to the GettingStarted guide, for when npmlog module isn't found.
Solution copied from: tj/n#101 (comment)
Closes facebook#8994

Differential Revision: D3612345

Pulled By: JoelMarcey

fbshipit-source-id: 10e7381adc530bb97c795cae022da3525745122a
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GevaZeichner @JoelMarcey