Skip to content

fix: build settings for custom build configuration #43780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: build settings for custom build configuration #43780

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7f50e2
fix: build settings for custom build configuration
jblarriviere Apr 2, 2024
68755dd
fix: match *Debug* custom configuration instead of *Debug
jblarriviere Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/scripts/cocoapods/utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ def self.add_build_settings_to_pod(installer, settings_name, settings_value, tar
installer.target_installation_results.pod_target_installation_results.each do |pod_name, target_installation_result|
if pod_name.to_s == target_pod_name
target_installation_result.native_target.build_configurations.each do |config|
if configuration == nil || (configuration != nil && configuration == config.name)
if configuration == nil || (configuration != nil && config.name.ends_with?(configuration))
config.build_settings[settings_name] ||= '$(inherited) '
config.build_settings[settings_name] << settings_value
end
Expand Down