Skip to content

fix: PerfMonitor option not showing on iOS (Bridgeless) #42891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+8 −8
Closed

fix: PerfMonitor option not showing on iOS (Bridgeless) #42891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/react-native/React/CoreModules/RCTDevMenu.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,14 @@ - (void)setDefaultJSBundle
devSettings.isHotLoadingEnabled = !devSettings.isHotLoadingEnabled;
}]];
}

id perfMonitorItemOpaque = [_moduleRegistry moduleForName:"PerfMonitor"];
SEL devMenuItem = NSSelectorFromString(@"devMenuItem");
if ([perfMonitorItemOpaque respondsToSelector:devMenuItem]) {
RCTDevMenuItem *perfMonitorItem = [perfMonitorItemOpaque performSelector:devMenuItem];
[items addObject:perfMonitorItem];
}


[items
addObject:[RCTDevMenuItem
Expand Down
8 changes: 0 additions & 8 deletions packages/react-native/React/CoreModules/RCTPerfMonitor.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ static vm_size_t RCTGetResidentMemorySize(void)
@interface RCTPerfMonitor : NSObject <
RCTBridgeModule,
RCTTurboModule,
RCTInitializing,
RCTInvalidating,
UITableViewDataSource,
UITableViewDelegate>
Expand Down Expand Up @@ -131,13 +130,6 @@ - (dispatch_queue_t)methodQueue
return dispatch_get_main_queue();
}

- (void)initialize
{
#if __has_include(<React/RCTDevMenu.h>)
[(RCTDevMenu *)[_moduleRegistry moduleForName:"DevMenu"] addItem:self.devMenuItem];
#endif
}

- (void)invalidate
{
[self hide];
Expand Down