Update Metro to ^0.80.0 - don't pin to exact version #41219
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50731999 |
Summary: Bump to the latest Metro release. This includes minor breaking changes to Metro subpackages that should *not* be visible to RN users. Metro release notes: https://github.com/facebook/metro/releases/tag/v0.80.0 ## Moving to unpinned versioning Metro is a multi-package project, and not pinning to an exact version means multiple versions of `metro*` packages may appear in an RN project. This isn't unusual in the NPM ecosystem and *shouldn't* be a problem, but historically has caused issues (eg facebook#34714, facebook/metro#1017). The root cause of all of these issues, as far as we know, was fixed in facebook/metro@6d46078, a bug where Node hierarchical resolution was effectively sidestepped via a relative worker path, resulting in a mismatch between transformer and host process. In addition, the fact that `react-refresh`, `metro-react-native-babel-transformer` and `metro-react-native-babel-preset` are now fully moved into the `react-native/` scope and versioned with React Native means there are no circular dependencies between React Native and Metro, explicit or implicit, and we're much more clearly decoupled. So, we're moving to caret versioning to allow React Native users to pick up Metro fixes and features without requiring React Native releases and user upgrades. Changelog: [General][Changed] - Update Metro to ^v0.80.0, stop pinning to an exact version Reviewed By: GijsWeterings Differential Revision: D50731999
robhogan
force-pushed
the
export-D50731999
branch
from
92e6a0d to
99f54be
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50731999 |
Contributor
|
This pull request has been merged in 7853b06. |
21 tasks
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Oct 30, 2023
Summary: Pull Request resolved: facebook#41219 Bump to the latest Metro release. This includes minor breaking changes to Metro subpackages that should *not* be visible to RN users. Metro release notes: https://github.com/facebook/metro/releases/tag/v0.80.0 ## Moving to unpinned versioning Metro is a multi-package project, and not pinning to an exact version means multiple versions of `metro*` packages may appear in an RN project. This isn't unusual in the NPM ecosystem and *shouldn't* be a problem, but historically has caused issues (eg facebook#34714, facebook/metro#1017). The root cause of all of these issues, as far as we know, was fixed in facebook/metro@6d46078, a bug where Node hierarchical resolution was effectively sidestepped via a relative worker path, resulting in a mismatch between transformer and host process. In addition, the fact that `react-refresh`, `metro-react-native-babel-transformer` and `metro-react-native-babel-preset` are now fully moved into the `react-native/` scope and versioned with React Native means there are no circular dependencies between React Native and Metro, explicit or implicit, and we're much more clearly decoupled. So, we're moving to caret versioning to allow React Native users to pick up Metro fixes and features without requiring React Native releases and user upgrades. Changelog: [General][Changed] - Update Metro to ^v0.80.0, stop pinning to an exact version Reviewed By: GijsWeterings Differential Revision: D50731999 fbshipit-source-id: 57b07bf73c0b31f392c4d36376ca48b48a8bd598
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Bump to the latest Metro release. This includes minor breaking changes to Metro subpackages that should not be visible to RN users.
Metro release notes: https://github.com/facebook/metro/releases/tag/v0.80.0
Moving to unpinned versioning
Metro is a multi-package project, and not pinning to an exact version means multiple versions of
metro*packages may appear in an RN project.This isn't unusual in the NPM ecosystem and shouldn't be a problem, but historically has caused issues (eg #34714, facebook/metro#1017). The root cause of all of these issues, as far as we know, was fixed in facebook/metro@6d46078, a bug where Node hierarchical resolution was effectively sidestepped via a relative worker path, resulting in a mismatch between transformer and host process.
In addition, the fact that
react-refresh,metro-react-native-babel-transformerandmetro-react-native-babel-presetare now fully moved into thereact-native/scope and versioned with React Native means there are no circular dependencies between React Native and Metro, explicit or implicit, and we're much more clearly decoupled.So, we're moving to caret versioning to allow React Native users to pick up Metro fixes and features without requiring React Native releases and user upgrades.
Changelog:
[General][Changed] - Update Metro to ^v0.80.0, stop pinning to an exact version
Differential Revision: D50731999