rntester Android > Don't call rncore_ModuleProvider(name, params) twice #40758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50109991 |
|
This pull request was exported from Phabricator. Differential Revision: D50109991 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 10, 2023
…ce (facebook#40758) Summary: Pull Request resolved: facebook#40758 This is a follow up to facebook#39987 As we already call ``` return rncore_ModuleProvider(name, params); ``` in: https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultTurboModuleManagerDelegate.cpp#L55 we don't have to do it again in: https://github.com/facebook/react-native/blob/main/packages/rn-tester/android/app/src/main/jni/OnLoad.cpp#L53 Changelog: [Internal] Differential Revision: D50109991 fbshipit-source-id: 7583246554875f26c8a07140d9b3a91c92a06ce2
christophpurrer
force-pushed
the
export-D50109991
branch
from
4ed0c45 to
7c80381
Compare
Base commit: b13ea17 |
…ce (facebook#40758) Summary: This is a follow up to facebook#39987 As we already call ``` return rncore_ModuleProvider(name, params); ``` in: https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultTurboModuleManagerDelegate.cpp#L55 we don't have to do it again in: https://github.com/facebook/react-native/blob/main/packages/rn-tester/android/app/src/main/jni/OnLoad.cpp#L53 Changelog: [Internal] Reviewed By: cortinico Differential Revision: D50109991
christophpurrer
force-pushed
the
export-D50109991
branch
from
7c80381 to
8b2407a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50109991 |
|
This pull request has been merged in 4e92f60. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a follow up to #39987
As we already call
in:
https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultTurboModuleManagerDelegate.cpp#L55
we don't have to do it again in:
https://github.com/facebook/react-native/blob/main/packages/rn-tester/android/app/src/main/jni/OnLoad.cpp#L53
Changelog: [Internal]
Differential Revision: D50109991