Skip to content

Conversation

@mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Oct 2, 2023

Summary:
deduplicate code in cleanDataFromModules

chnagelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D49834866

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Oct 2, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49834866

@analysis-bot
Copy link

analysis-bot commented Oct 2, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,901,400 -3
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,380,168 -5
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 72d0fed
Branch: main

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 2df832f

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49834866

mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 3, 2023
Summary:
Pull Request resolved: facebook#39767

deduplicate code in cleanDataFromModules

changelog: [internal] internal

bypass-github-export-checks

Reviewed By: cortinico

Differential Revision: D49834866

fbshipit-source-id: b6fd568352669342499fdc762697ec55d9679240
Summary:
Mark ReactNativeHost as deprecated In new architecture

chnagelog: [internal] internal

Differential Revision: D49834869

fbshipit-source-id: 237cfc0ebdcabab0997487b0e451591ca4ba5940
Summary:
Update deprecation documentation

chnagelog: [internal] internal

Differential Revision: D49834868

fbshipit-source-id: 4eee395d57e00c1673daf0046fcbb78c72132537
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49834866

Summary:
Pull Request resolved: facebook#39767

deduplicate code in cleanDataFromModules

changelog: [internal] internal

bypass-github-export-checks

Reviewed By: cortinico

Differential Revision: D49834866

fbshipit-source-id: 8fcd419598c03d517a190719dc67afcd9f4a3d8c
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 4, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 353d8d3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants