Disable bitcode from Hermes #37868
Closed
Disable bitcode from Hermes #37868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46704633 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D46704633 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 13, 2023
Summary: Pull Request resolved: facebook#37868 Thanks to the help of the community, we discovered that we can safely disable the bitcode setting in Hermes. Community testing reported that the tarball size get reduced from ~500 Mb to ~25 Mb, a x20 reduction ## Changelog: [iOS][Changed] - Disabled bitcode for Hermes prebuilts Reviewed By: dmytrorykun Differential Revision: D46704633 fbshipit-source-id: 094ede2c96427982e378901001b2137a5788cc23
cipolleschi
force-pushed
the
export-D46704633
branch
from
b2b4f86 to
639fb35
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 13, 2023
Summary: Pull Request resolved: facebook#37868 Thanks to the help of the community, we discovered that we can safely disable the bitcode setting in Hermes. Community testing reported that the tarball size get reduced from ~500 Mb to ~25 Mb, a x20 reduction ## Changelog: [iOS][Changed] - Disabled bitcode for Hermes prebuilts Reviewed By: dmytrorykun Differential Revision: D46704633 fbshipit-source-id: 31413f6d52c070568496fa7727360234cb1bfc22
cipolleschi
force-pushed
the
export-D46704633
branch
from
639fb35 to
498d89c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46704633 |
Summary: Pull Request resolved: facebook#37868 Thanks to the help of the community, we discovered that we can safely disable the bitcode setting in Hermes. Community testing reported that the tarball size get reduced from ~500 Mb to ~25 Mb, a x20 reduction ## Changelog: [iOS][Changed] - Disabled bitcode for Hermes prebuilts Reviewed By: dmytrorykun Differential Revision: D46704633 fbshipit-source-id: 06913d5819a9421c24aada59f8e19c8ecac70225
cipolleschi
force-pushed
the
export-D46704633
branch
from
498d89c to
06a4d86
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46704633 |
Base commit: af99a68 |
|
This pull request has been merged in de6bfec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Thanks to the help of the community, we discovered that we can safely disable the bitcode setting in Hermes.
Community testing reported that the tarball size get reduced from ~500 Mb to ~25 Mb, a x20 reduction
Changelog:
[iOS][Changed] - Disabled bitcode for Hermes prebuilts
Differential Revision: D46704633