Skip to content

Conversation

@tarunrajput
Copy link
Contributor

@tarunrajput tarunrajput commented May 9, 2023

Summary:

Part of Codegen Issue: #34872

Add a typeAlias: string property to the Parser class. Implement it in the Flow parser so that it returns TypeAlias and in
the TypeScriptParser so that it returns TSTypeAliasDeclaration. Replace the case in the switch in the parsers/flow/utils.js and parsers/typescript/utils.js with this prop.

Changelog:

[Internal][Added]: Add typeAlias property in parsers

Test Plan:

yarn test

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 9, 2023
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! 👏

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

analysis-bot commented May 9, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,732,590 -3
android hermes armeabi-v7a 8,043,921 -4
android hermes x86 9,221,936 -4
android hermes x86_64 9,074,913 +1
android jsc arm64-v8a 9,297,786 +0
android jsc armeabi-v7a 8,486,551 -1
android jsc x86 9,358,530 -2
android jsc x86_64 9,615,112 -1

Base commit: d8ced6f
Branch: main

@tarunrajput tarunrajput force-pushed the add-typeAlias-property-in-parser branch from da18d82 to cb03244 Compare May 10, 2023 15:23
@cipolleschi
Copy link
Contributor

Sorry, this now need a rebase and conflict resolution. :(

@tarunrajput tarunrajput force-pushed the add-typeAlias-property-in-parser branch from cb03244 to e5cc8ae Compare May 11, 2023 14:57
@tarunrajput
Copy link
Contributor Author

Sorry, this now need a rebase and conflict resolution. :(

No worries, I have rebased and resolved the conflicts.

@cipolleschi
Copy link
Contributor

/rebase

@github-actions github-actions bot force-pushed the add-typeAlias-property-in-parser branch from e5cc8ae to ef41d20 Compare May 15, 2023 12:25
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 17, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 0de4768.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants