refactor(codegen): extract throwIfArgumentPropsAreNull function in error-utils

[AntoineDoubovetzky]

Summary:

This PR contains task 117 from #34872:

[Codegen 117] Extract the code that throws if argumentProps are null in a throwIfArgumentPropsAreNull function in the error-utils.js file. Use it in the flow/components/events.js and in the typescript/components/event.js files

Changelog:

[Internal] [Changed] - Extract throwIfArgumentPropsAreNull function in error-utils

Test Plan:

I tested using Jest and Flow commands.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,732,589	-4
android	hermes	armeabi-v7a	8,043,921	-4
android	hermes	x86	9,221,935	-5
android	hermes	x86_64	9,074,911	-1
android	jsc	arm64-v8a	9,297,786	+0
android	jsc	armeabi-v7a	8,486,549	-3
android	jsc	x86	9,358,528	-4
android	jsc	x86_64	9,615,108	-5

Base commit: d8ced6f
Branch: main

[dmytrorykun]

This can be simplified to just:

throwIfArgumentPropsAreNull(argumentProps, name);
throwIfBubblingTypeIsNull(bubblingType, name);

[AntoineDoubovetzky]

I tried, but there is a Flow error in the returned object because Flow doesn't infer that argumentProps and bubblingType cannot be null.
Do you know a way to fix this?

[cipolleschi]

So, the goal is to remove the if-else as Dmitry suggested. 🤔

one way could be to:

1. Define a type alias like type ArgumentProps = $FlowFixMe
2. Have throwIfArgumentPropsAreNull return ArgumentProps (not nullable)
3. invoke it like argumentProps = throwIfArgumentPropsAreNull(argumentProps, name);

A bit ugly, but it should do the trick.

Otherwise, we can actually suppress the warning with a // eslint-disable-next-line <name of the broken rule> as we are actually sure that the props can't be null now.

I'm okay with both approaches!

[AntoineDoubovetzky]

I chose the first option. Even though I don't like having to make the code more complex for typing reasons, I think it's safer.

[cipolleschi]

Thank you for taking the time to work on this changes. I left a comment to help solving the situation!

[cipolleschi]

Thank you for working on this and to solve the issue. Do you have time to also rebase and fix the conflicts, please? 🙏

[AntoineDoubovetzky]

Thank you for working on this and to solve the issue. Do you have time to also rebase and fix the conflicts, please? 🙏

Done!

[cipolleschi]

/rebase

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi merged this pull request in f05252a.