AGP to 8.0.2 #37019
Closed
AGP to 8.0.2 #37019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45178748 |
Contributor
Author
|
Pending a change on |
cortinico
force-pushed
the
export-D45178748
branch
from
c08dcf5 to
9bcaf83
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45178748 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45178748 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jun 19, 2023
Summary: Pull Request resolved: facebook#37019 This bumps the version of AGP to the latest stable. There was a breaking change in how buildConfig are built which I had to handle. This also requires a bump of RNGP to work correctly. Moreover, we now required Java 17 to build Android apps (as that's a AGP requirement). Changelog: [Android] [Changed] - Java to 17 and AGP to 8.0.2 Differential Revision: D45178748 fbshipit-source-id: cf49129430ea5a0a058376c1951f2a493e7218e0
cortinico
force-pushed
the
export-D45178748
branch
from
9bcaf83 to
5572d1d
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jun 20, 2023
Summary: Pull Request resolved: facebook#37019 This bumps the version of AGP to the latest stable. There was a breaking change in how buildConfig are built which I had to handle. This also requires a bump of RNGP to work correctly. Moreover, we now required Java 17 to build Android apps (as that's a AGP requirement). Changelog: [Android] [Changed] - Java to 17 and AGP to 8.0.2 Differential Revision: D45178748 fbshipit-source-id: 523cf93431b2ce58cbb9b6058b90dff433ec0e0b
cortinico
force-pushed
the
export-D45178748
branch
from
5572d1d to
9696391
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45178748 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jun 20, 2023
Summary: Pull Request resolved: facebook#37019 This bumps the version of AGP to the latest stable. There was a breaking change in how buildConfig are built which I had to handle. This also requires a bump of RNGP to work correctly. Moreover, we now required Java 17 to build Android apps (as that's a AGP requirement). Changelog: [Android] [Changed] - Java to 17 and AGP to 8.0.2 Differential Revision: D45178748 fbshipit-source-id: f0338e7d276a65ede777838804096225eebdc055
cortinico
force-pushed
the
export-D45178748
branch
from
9696391 to
8faf3ea
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45178748 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45178748 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jun 20, 2023
Summary: Pull Request resolved: facebook#37019 This bumps the version of AGP to the latest stable. There was a breaking change in how buildConfig are built which I had to handle. This also requires a bump of RNGP to work correctly. Moreover, we now required Java 17 to build Android apps (as that's a AGP requirement). Changelog: [Android] [Changed] - Java to 17 and AGP to 8.0.2 Differential Revision: D45178748 fbshipit-source-id: 41f9453012d74acbff45b7f87da2a5cc95f11458
cortinico
force-pushed
the
export-D45178748
branch
from
8faf3ea to
7842671
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jun 20, 2023
Summary: Pull Request resolved: facebook#37019 This bumps the version of AGP to the latest stable. There was a breaking change in how buildConfig are built which I had to handle. This also requires a bump of RNGP to work correctly. Moreover, we now required Java 17 to build Android apps (as that's a AGP requirement). Changelog: [Android] [Changed] - Java to 17 and AGP to 8.0.2 Differential Revision: D45178748 fbshipit-source-id: 61a65e7c17fc75497b2923f4422e71137b095b1f
cortinico
force-pushed
the
export-D45178748
branch
from
7842671 to
b1eabb2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45178748 |
Closed
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jun 20, 2023
Summary: Pull Request resolved: facebook#37019 This bumps the version of AGP to the latest stable. There was a breaking change in how buildConfig are built which I had to handle. This also requires a bump of RNGP to work correctly. Moreover, we now required Java 17 to build Android apps (as that's a AGP requirement). Changelog: [Android] [Changed] - Java to 17 and AGP to 8.0.2 Differential Revision: D45178748 fbshipit-source-id: 2ccfc7b92edad7c982b576c921c2b6209ae0c4d7
cortinico
force-pushed
the
export-D45178748
branch
from
b1eabb2 to
0de3944
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45178748 |
Base commit: cba13bb |
Summary: Pull Request resolved: facebook#37019 This bumps the version of AGP to the latest stable. There was a breaking change in how buildConfig are built which I had to handle. This also requires a bump of RNGP to work correctly. Moreover, we now required Java 17 to build Android apps (as that's a AGP requirement). Changelog: [Android] [Changed] - Java to 17 and AGP to 8.0.2 Reviewed By: cipolleschi Differential Revision: D45178748 fbshipit-source-id: f5e331a50983a84fc878f6c2bffcb90f0806c2d6
cortinico
force-pushed
the
export-D45178748
branch
from
0de3944 to
e78a96c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45178748 |
Contributor
|
This pull request has been merged in 9f7dddf. |
This was referenced Nov 3, 2023
yayvery
pushed a commit
to discord/react-native
that referenced
this pull request
Jan 14, 2024
Summary: Pull Request resolved: facebook#37019 This bumps the version of AGP to the latest stable. There was a breaking change in how buildConfig are built which I had to handle. This also requires a bump of RNGP to work correctly. Moreover, we now required Java 17 to build Android apps (as that's a AGP requirement). Changelog: [Android] [Changed] - Java to 17 and AGP to 8.0.2 Reviewed By: cipolleschi Differential Revision: D45178748 fbshipit-source-id: 0f302e1f2f2ee56bd3566202fbb5ef67c9b220db
yayvery
pushed a commit
to discord/react-native
that referenced
this pull request
Jan 14, 2024
Summary: Pull Request resolved: facebook#37019 This bumps the version of AGP to the latest stable. There was a breaking change in how buildConfig are built which I had to handle. This also requires a bump of RNGP to work correctly. Moreover, we now required Java 17 to build Android apps (as that's a AGP requirement). Changelog: [Android] [Changed] - Java to 17 and AGP to 8.0.2 Reviewed By: cipolleschi Differential Revision: D45178748 fbshipit-source-id: 0f302e1f2f2ee56bd3566202fbb5ef67c9b220db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This bumps the version of AGP to the latest stable.
There was a breaking change in how buildConfig are built which I had to handle.
This also requires a bump of RNGP to work correctly.
Changelog:
[Android] [Changed] - AGP to 8.0.0
Differential Revision: D45178748