-
Notifications
You must be signed in to change notification settings - Fork 24.9k
1/5 Avoid using transform scaleY or scaleX in inverted flatlist when TalkBack and enabledTalkbackCompatibleInvertedList prop are enabled #34141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
fabOnReact
wants to merge
134
commits into
facebook:main
from
fabOnReact:inverted-flatlist-accessibility
Closed
Changes from all commits
Commits
Show all changes
134 commits
Select commit
Hold shift + click to select a range
5b2cb47
draft - invert flatlist without using transform
fabOnReact 06fb1dd
adding comments to scroll to top/bottom optimization
fabOnReact f72cac2
draft
fabOnReact e53aa54
workaround scrollToEnd issues for inverted flatlist
fabOnReact 4c08d7c
adding flatlist nested example
fabOnReact 24c612c
improve scrollToTop functionality when new item added
fabOnReact 6215dc9
adding test case remove an item
fabOnReact 85f3a42
fix circleci failures
fabOnReact 389487b
remove line fullScroll
fabOnReact 050a629
Merge branch 'main' into inverted-flatlist-accessibility
fabOnReact c43c832
trigger scrollToEnd on not-nested flatlist
fabOnReact 0eb74c6
Last item added/deleted in vertical flatlist does not adjust scroll p…
fabOnReact 98bea1b
fix circle ci errors
fabOnReact 6271850
re-introduce cellStyle flexDirection row
fabOnReact e640998
fix delete item inverted flatlist scrollToEnd
fabOnReact c47a75a
add/remove button for inverted flatlist example
fabOnReact c793c3b
flatlist-inverted ex add buttons
fabOnReact c281788
draft - when items are appended to the end of the list, the view need…
fabOnReact acddd08
draft - logic only used with ScreenReader and Inverted Flatlist
fabOnReact 94d1246
use custom inversion logic for TalkBack (no android condition yet added)
fabOnReact 543a9e4
adding explanatory comments
fabOnReact d627812
fix typo - isScreenReaderEnabled instead of screenreaderEnabled
fabOnReact 87c88bd
adapt logic to horizontal scroll view
fabOnReact 5e81716
when items are appended to the end of the list, the view needs to sta…
fabOnReact 509931d
adding check on Platform Android
fabOnReact f779f9d
remove event listener on AccessibilityInfo
fabOnReact 0c75c4d
adding EventSubcription type to this._screenreaderEventListener
fabOnReact 8e58058
adding screenreaderEnabled to State type
fabOnReact 6cb1dec
fix return type from method getDerivedStateFromProps
fabOnReact a506b51
remove changes to ScrollProps
fabOnReact f9b64bd
run yarn test -u
fabOnReact 3cfe035
adding log message in case AccessibilityInfo.isScreenReaderEnabled fails
fabOnReact c163c54
TalkBack inverted FlatList _maybeCallOnEndReached custom behaviour
fabOnReact adff29f
when items appended, view stays in same position
fabOnReact 88c68b2
draft - TalkBack onEndReached scroll Position
fabOnReact 9bdaa47
fix onEndReached callback triggering multiple times
fabOnReact 36e0ace
fix scrolling top does not trigger after long time
fabOnReact 0d1cf47
remove state.height and resetScrollPosition
fabOnReact f670f19
Test Case for issue scrollview triggers a scrollToTop when scrolling …
fabOnReact 193e9f4
fix scrollTo bottom/top when scolling fast down
fabOnReact ffe959e
remove console.log statements added for debugging
fabOnReact f2768ab
remove setTimeout when calling scrollToOffset
fabOnReact 0912944
onMomentumScrollEnd does not work with talkback
fabOnReact 3843514
scrollToEnd TalkBack Inverted Flatlist
fabOnReact b4abedd
adding scroll to end to example
fabOnReact 3b6fe66
keep scroll position infinite horizontal flatlist
fabOnReact 880fd80
upating logic that triggers first scroll to the end
fabOnReact 72aaa2b
componentWillUnmount - clear variables
fabOnReact 079fbfa
inverted example - adding header and footer
fabOnReact a3b8e1c
initialize variables in constructor
fabOnReact 4b4c7a5
remove changes to flatlist-basic
fabOnReact 3df9a90
fix issue lastTimeCalled not numberic and ref type
fabOnReact dfef050
fix regression in initialScrollIndex and scrollToIndex
fabOnReact 239d31d
remove already decl variables
fabOnReact 891c4f1
remove bottomHeight from state
fabOnReact 6451aab
fix check on TalkBack Inverted FlatList
fabOnReact 9cbc554
adding prop enableTalkbackCompatibleInvertedList
fabOnReact 7b307d5
rename variables
fabOnReact a4ef645
adding test for scrollToIndex with TalkBack
fabOnReact c41e1c8
adding info about not supported initialScrollIndes
fabOnReact 3d2067c
removing not relevant code from rn-tester
fabOnReact 9d89b60
minor changes
fabOnReact c3c2a1b
remove setTimeout in scrollToOffset for infinite scroll
fabOnReact 405d9fc
reintroduce setTimeout required for infinite scroll
fabOnReact 9a894e9
improving conditions to enable functionality
fabOnReact e9f9715
adding test to press on inverted flatlist item
fabOnReact b0d2521
adding screenreaderEnabled to getDerivedStateFromProps
fabOnReact c96f635
Merge branch 'main' into inverted-flatlist-accessibility
fabOnReact 879c93f
Merge branch 'main' into inverted-flatlist-accessibility
fabOnReact bf78345
adding clearTimeout to clear timer on componentWillUnmount
fabOnReact 30960cf
Merge branch 'main' into inverted-flatlist-accessibility
fabOnReact f7e5efc
Merge branch 'main' into inverted-flatlist-accessibility
fabOnReact 56e7be1
Merge branch 'main' into inverted-flatlist-accessibility
fabOnReact 6214e29
Merge branch 'main' into inverted-flatlist-accessibility
fabOnReact d5c845e
Props are moved to VirtualizedListProps
fabOnReact 436fbed
remove import for Platform
fabOnReact c7b2200
remove changes to flatlist-inverted
fabOnReact 93e4e88
pullbot issues VirtualizedList
fabOnReact ce9b0aa
minor changes
fabOnReact 48b4a4b
pullbot issues VirtualizedList
fabOnReact a8640c3
trying to fix circleci errors
fabOnReact 5f7dbc6
Merge branch 'main' into inverted-flatlist-accessibility
fabOnReact ceddbcd
VirList circleci errors
fabOnReact 4e7bb10
avoid changing VirtUtils shared types with VirtList Experimental
fabOnReact a903479
remove change from VirtListExperimental
fabOnReact 9943970
minor changes
fabOnReact 4091984
Merge branch 'main' into inverted-flatlist-accessibility
fabOnReact c7d0d22
draft example
fabOnReact b5ff683
adding talkback mocked value to example
fabOnReact 4266625
updating example to use column-reverse
fabOnReact 496cc49
adding column-reverse to FlatList contentContainerStyle and style
fabOnReact b3050bd
commit updates to the example
fabOnReact f43ac61
WIP - column-reverse, handle short list, fix issues
fabOnReact 777e282
remove comments from github actions
fabOnReact 6e3aff2
flatlist example without infinite list
fabOnReact aaada22
Test functionality with the infinite list (commit b3050bd637d)
fabOnReact 5546b72
The infinite list does not work when TalkBack is enabled
fabOnReact 0a588d5
vertical and horizontal infinite list
fabOnReact ed87a1c
trigger initial scroll position in Java
fabOnReact ba904fb
fix issue with scrolling in infinite list
fabOnReact b4ef1a3
Merge branch 'main' into inverted-flatlist-accessibility
fabOnReact 3b4ca19
minor changes
fabOnReact 8f1a234
minor changes
fabOnReact ffe5c81
Revert "trigger initial scroll position in Java"
fabOnReact 0064acc
remove platform checks
fabOnReact 82768f7
_maybeCallOnEndReached from PR #26444
fabOnReact 3242de0
adapting #26444 to solve issue #30373
fabOnReact 0617ce4
Revert "Revert "trigger initial scroll position in Java""
fabOnReact 36776e9
working solution (with some issues) on Android and iOS
fabOnReact b3b3096
working implementation for iOS and Android
fabOnReact 4cf5c16
move onEndReached logic for inverted list to example
fabOnReact b708ed9
review Java functionalities
fabOnReact 8abdfb7
Code Review JavaScript Functionalities
fabOnReact 5919a6e
fixing issues with _hasTriggeredInitialScrollToIndex race condition
fabOnReact 036f088
circle ci eslint checks on example
fabOnReact 7206a4d
Merge branch 'main' into inverted-flatlist-accessibility
fabOnReact 6690eeb
rename component in example
fabOnReact e18ac41
disabled contentOffset if talkback is not enabled
fabOnReact 8c8e68e
fix flow errors circleci
fabOnReact 099b806
quick fix flow errors example
fabOnReact 66be76f
avoid over-riding props.style and props.contentContainerStyle
fabOnReact 81e6116
inverted flatlist start from the end
fabOnReact 8a1df99
using destructured variables
fabOnReact 7f543e6
re-enable _scheduleCellsToRenderUpdate for TalkBack
fabOnReact 9202414
adding log warning for not compatible functionalities
fabOnReact 9b141b9
eslint fix check
fabOnReact 10056e4
minor fix to example
fabOnReact a93d8c1
avoid trigger scroll to bottom with contentOffset after first scroll
fabOnReact 1106350
move variable declaration
fabOnReact 223da5d
avoid setting contentOffset if contentLength == 0
fabOnReact 6bb091c
move contentOffset to rn-tester example
fabOnReact 7ee21a5
fix circleci
fabOnReact 94db868
fix circleci
fabOnReact 80d2343
avoid trigger multiple time contentOffset in example
fabOnReact File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.