Fix enableVmCleanup not working for apps with product flavors. #32422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lugin Summary: While working on the NDK AGP Apis, I realized the the `applyAppPlugin` is accessed too early inside the Gradle plugin. Specifically is accessed once the plugin is applied, and the extension is not configured afterwards. This means that the extension is always set the default values. I'm fixing it moving it inside the `project.afterEvaluate` that was already need to access the variant informations. Changelog: [Internal] [Changed] - Fix applyAppPlugin being accessed too early in the React App Gradle Plugin Differential Revision: D31652984 fbshipit-source-id: d8dddca1e0e3d3f8958b122350017f9d9e81d216
Summary: While working on the NDK AGP Api I realized that the `enableVmCleanup` function, that is supposed to cleanup the extra `.so` files from the final artifacts, is broken for apps with variants. Specifically say for a `liteDebug` app it tries to search for `.so` files inside: ``` intermediates/stripped_native_libs/lite/debug/out/lib ``` while the `.so` files are located inside: ``` intermediates/stripped_native_libs/liteDebug/out/lib ``` I've fixed changing the token of the path from `targetPath` to `variant.name` Changelog: [Android] [Fixed] - Fix enableVmCleanup not working for apps with product flavors Reviewed By: ShikaSD Differential Revision: D31654704 fbshipit-source-id: 50998fd0f7384c153f36367f8abcc20746ab0945
facebook-github-bot
added
p: Facebook
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D31654704 |
|
|
PR build artifact for 6ea08ec is ready. |
Base commit: dfe42d6 |
Base commit: dfe42d6 |
Contributor
|
This pull request has been merged in a2b5e4c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While working on the NDK AGP Api I realized that the
enableVmCleanupfunction,that is supposed to cleanup the extra
.sofiles from the final artifacts, is brokenfor apps with variants. Specifically say for a
liteDebugapp it tries to search for.sofiles inside:while the
.sofiles are located inside:I've fixed changing the token of the path from
targetPathtovariant.nameChangelog:
[Android] [Fixed] - Fix enableVmCleanup not working for apps with product flavors
Reviewed By: ShikaSD
Differential Revision: D31654704