gradle vm cleanup fix #32257

enniel · 2021-09-24T08:22:23Z

Summary

This patch remove unused .so files for reduce android .apk and .aab

Changelog

[Android] [Fixed] - Exclude unused .so files for reduce android .apk and .aab

Test Plan

I have created a repository for testing:
https://github.com/enniel/react-native-invalid-build-example

That lines includes patch for fix bug:
https://github.com/enniel/react-native-invalid-build-example/blob/f195ecdbeaca88ffb57c344615ede45ea0f6ef57/android/app/react.gradle#L331-L385

git clone https://github.com/enniel/react-native-invalid-build-example
cd react-native-invalid-build-example
npm i

debug, hermes disabled, without patch

git switch hermes-disabled-without-patch
npm run build:android:debug:apk

open android/app/build/outputs/apk/debug/app-debug.apk in android studio

debug, hermes enabled, without patch

git switch hermes-enabled-without-patch
npm run build:android:debug:apk

open android/app/build/outputs/apk/debug/app-debug.apk in android studio

debug, hermes disabled, with patch

git switch hermes-disabled-with-patch
npm run build:android:debug:apk

open android/app/build/outputs/apk/debug/app-debug.apk in android studio

debug, hermes enabled, with patch

git switch hermes-enabled-with-patch
npm run build:android:debug:apk

open android/app/build/outputs/apk/debug/app-debug.apk in android studio

release, hermes disabled, without patch

git switch hermes-disabled-without-patch
npm run build:android:release:apk

open android/app/build/outputs/apk/release/app-release.apk in android studio

release, hermes enabled, without patch

git switch hermes-enabled-without-patch
npm run build:android:release:apk

open android/app/build/outputs/apk/release/app-release.apk in android studio

release, hermes disabled, with patch

git switch hermes-disabled-with-patch
npm run build:android:release:apk

open android/app/build/outputs/apk/release/app-release.apk in android studio

release, hermes enabled, with patch

git switch hermes-enabled-with-patch
npm run build:android:release:apk

open android/app/build/outputs/apk/release/app-release.apk in android studio

facebook-github-bot · 2021-09-24T08:22:27Z

Hi @enniel!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

analysis-bot · 2021-09-24T08:51:14Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,706,017	-3,452
android	hermes	armeabi-v7a	7,236,134	-3,320
android	hermes	x86	8,126,071	-3,860
android	hermes	x86_64	8,091,037	-4,094
android	jsc	arm64-v8a	9,625,917	-3,061
android	jsc	armeabi-v7a	8,543,561	-2,930
android	jsc	x86	9,640,254	-3,470
android	jsc	x86_64	10,248,905	-3,715

Base commit: 18697ad

analysis-bot · 2021-09-24T08:51:29Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 18697ad

facebook-github-bot · 2021-09-24T09:03:19Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot · 2021-09-24T09:06:16Z

@ShikaSD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ecreeth · 2021-09-24T13:32:02Z

Awesome! these are my results:

release, hermes disabled, without patch

debug, hermes disabled, without patch

debug, hermes enabled, without patch

debug, hermes disabled, with patch

debug, hermes enabled, with patch

release, hermes enabled, without patch

release, hermes disabled, with patch

release, hermes enabled, with patch

cortinico · 2021-09-24T13:42:58Z

This is great stuff! Thanks for looking into it @enniel
Just one note: would you be able to re-apply the same logic also here:

react-native/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/TaskConfiguration.kt

Lines 194 to 228 in 382e78e

    
           private fun Project.cleanupVMFiles(enableHermes: Boolean, isRelease: Boolean, targetPath: String) { 
        
             // Delete the VM related libraries that this build doesn't need. 
        
             // The application can manage this manually by setting 'enableVmCleanup: false' 
        
             // 
        
             // This should really be done by packaging all Hermes related libs into 
        
             // two separate HermesDebug and HermesRelease AARs, but until then we'll 
        
             // kludge it by deleting the .so files out of the /transforms/ directory. 
        
             val libDir = "$buildDir/intermediates/transforms/" 
        
             fileTree(libDir) { 
        
               if (enableHermes) { 
        
                 // For Hermes, delete all the libjsc* files 
        
                 it.include("**/libjsc*.so") 
        
                 if (isRelease) { 
        
                   // Reduce size by deleting the debugger/inspector 
        
                   it.include("**/libhermes-inspector.so") 
        
                   it.include("**/libhermes-executor-debug.so") 
        
                 } else { 
        
                   // Release libs take precedence and must be removed 
        
                   // to allow debugging 
        
                   it.include("**/libhermes-executor-release.so") 
        
                 } 
        
               } else { 
        
                 // For JSC, delete all the libhermes* files 
        
                 it.include("**/libhermes*.so") 
        
               } 
        
             } 
        
                 .visit { visit -> 
        
                   val targetVariant = ".*/transforms/[^/]*/$targetPath/.*".toRegex() 
        
                   val path = visit.file.absolutePath.replace(File.separatorChar, '/') 
        
                   if (path.matches(targetVariant) && visit.file.isFile) { 
        
                     visit.file.delete() 
        
                   } 
        
                 } 
        
           }

enniel · 2021-09-26T05:09:28Z

This is great stuff! Thanks for looking into it @enniel
Just one note: would you be able to re-apply the same logic also here:

react-native/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/TaskConfiguration.kt

Lines 194 to 228 in 382e78e

private fun Project.cleanupVMFiles(enableHermes: Boolean, isRelease: Boolean, targetPath: String) {

// Delete the VM related libraries that this build doesn't need.

// The application can manage this manually by setting 'enableVmCleanup: false'

//

// This should really be done by packaging all Hermes related libs into

// two separate HermesDebug and HermesRelease AARs, but until then we'll

// kludge it by deleting the .so files out of the /transforms/ directory.

val libDir = "$buildDir/intermediates/transforms/"

fileTree(libDir) {

if (enableHermes) {

// For Hermes, delete all the libjsc* files

it.include("**/libjsc*.so")

if (isRelease) {

// Reduce size by deleting the debugger/inspector

it.include("**/libhermes-inspector.so")

it.include("**/libhermes-executor-debug.so")

} else {

// Release libs take precedence and must be removed

// to allow debugging

it.include("**/libhermes-executor-release.so")

}

} else {

// For JSC, delete all the libhermes* files

it.include("**/libhermes*.so")

}

}

.visit { visit ->

val targetVariant = ".*/transforms/[^/]*/$targetPath/.*".toRegex()

val path = visit.file.absolutePath.replace(File.separatorChar, '/')

if (path.matches(targetVariant) && visit.file.isFile) {

visit.file.delete()

}

}

}

Done!

facebook-github-bot · 2021-09-27T13:13:04Z

@ShikaSD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

cortinico · 2021-09-27T13:55:17Z

This is great stuff! Thanks for looking into it @enniel
Just one note: would you be able to re-apply the same logic also here:

react-native/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/TaskConfiguration.kt

Lines 194 to 228 in 382e78e

private fun Project.cleanupVMFiles(enableHermes: Boolean, isRelease: Boolean, targetPath: String) {

// Delete the VM related libraries that this build doesn't need.

// The application can manage this manually by setting 'enableVmCleanup: false'

//

// This should really be done by packaging all Hermes related libs into

// two separate HermesDebug and HermesRelease AARs, but until then we'll

// kludge it by deleting the .so files out of the /transforms/ directory.

val libDir = "$buildDir/intermediates/transforms/"

fileTree(libDir) {

if (enableHermes) {

// For Hermes, delete all the libjsc* files

it.include("**/libjsc*.so")

if (isRelease) {

// Reduce size by deleting the debugger/inspector

it.include("**/libhermes-inspector.so")

it.include("**/libhermes-executor-debug.so")

} else {

// Release libs take precedence and must be removed

// to allow debugging

it.include("**/libhermes-executor-release.so")

}

} else {

// For JSC, delete all the libhermes* files

it.include("**/libhermes*.so")

}

}

.visit { visit ->

val targetVariant = ".*/transforms/[^/]*/$targetPath/.*".toRegex()

val path = visit.file.absolutePath.replace(File.separatorChar, '/')

if (path.matches(targetVariant) && visit.file.isFile) {

visit.file.delete()

}

}

}

Done!

Thanks for doing that 🙏

react-native-bot · 2021-09-27T14:00:04Z

This pull request was successfully merged by @enniel in 6f12674.

^{When will my fix make it into a release? | Upcoming Releases}

react-native-bot · 2021-09-27T14:05:04Z

This pull request was successfully merged by @enniel in 6f12674.

^{When will my fix make it into a release? | Upcoming Releases}

react-native-bot · 2021-09-27T14:10:04Z

This pull request was successfully merged by @enniel in 6f12674.

^{When will my fix make it into a release? | Upcoming Releases}

react-native-bot · 2021-09-27T14:15:05Z

This pull request was successfully merged by @enniel in 6f12674.

^{When will my fix make it into a release? | Upcoming Releases}

gradle vm cleanup fix

3da35bc

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 24, 2021

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 24, 2021

react-native-gradle-plugin task configuration

3eb8b1f

facebook-github-bot closed this in 6f12674 Sep 27, 2021

charlesbdudley added the Merged This PR has been merged. label Oct 1, 2021

cortinico mentioned this pull request Oct 14, 2021

Android app-release.aab size and contains debug libraries like libhermes-inspector.so, etc... #32343

Closed

cortinico mentioned this pull request Jan 7, 2022

APK size got increased almost double after upgrading to RN 0.66.0 #32463

Closed

NamekMaster mentioned this pull request Apr 11, 2022

Caused by: java.lang.NullPointerException: Cannot invoke method doFirst() on null object #33609

Closed

gradle vm cleanup fix #32257

gradle vm cleanup fix #32257

Uh oh!

Conversation

enniel commented Sep 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changelog

Test Plan

Uh oh!

facebook-github-bot commented Sep 24, 2021

Action Required

Process

Uh oh!

analysis-bot commented Sep 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

analysis-bot commented Sep 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Sep 24, 2021

Uh oh!

facebook-github-bot commented Sep 24, 2021

Uh oh!

ecreeth commented Sep 24, 2021

Awesome! these are my results:

Uh oh!

cortinico commented Sep 24, 2021

Uh oh!

enniel commented Sep 26, 2021

Uh oh!

facebook-github-bot commented Sep 27, 2021

Uh oh!

cortinico commented Sep 27, 2021

Uh oh!

react-native-bot commented Sep 27, 2021

Uh oh!

react-native-bot commented Sep 27, 2021

Uh oh!

react-native-bot commented Sep 27, 2021

Uh oh!

react-native-bot commented Sep 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

enniel commented Sep 24, 2021 •

edited

Loading

analysis-bot commented Sep 24, 2021 •

edited

Loading

analysis-bot commented Sep 24, 2021 •

edited

Loading