Skip to content

Added Support for Entrance/exit from collection by Flatlist #31630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Added Support for Entrance/exit from collection by Flatlist #31630

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cfe057d
add support to announce "in list" and "out of list" in flatlist and s…
anaskhraza May 29, 2021
fce708e
Merge branch 'master' of https://github.com/facebook/react-native int…
anaskhraza May 29, 2021
d8cc980
Changed android.widget.ListView to android.widget.AbsListView to matc…
anaskhraza Jun 19, 2021
aad2f8f
Merge branch 'master' of https://github.com/facebook/react-native
anaskhraza Jun 19, 2021
8167667
Merge branch 'master' into accessibility/flatlist-announcement
anaskhraza Jun 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Libraries/Components/View/ViewAccessibility.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export type AccessibilityRole =
| 'tab'
| 'tablist'
| 'timer'
| 'list'
| 'toolbar';

// the info associated with an accessibility action
Expand Down
1 change: 1 addition & 0 deletions React/Views/RCTViewManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ @implementation RCTConvert (UIAccessibilityTraits)
@"tablist" : @(UIAccessibilityTraitNone),
@"timer" : @(UIAccessibilityTraitNone),
@"toolbar" : @(UIAccessibilityTraitNone),
@"list" : @(UIAccessibilityTraitNone),
}),
UIAccessibilityTraitNone,
unsignedLongLongValue)
Expand Down
3 changes: 3 additions & 0 deletions ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ public enum AccessibilityRole {
TAB,
TABLIST,
TIMER,
LIST,
TOOLBAR;

public static String getValue(AccessibilityRole role) {
Expand Down Expand Up @@ -135,6 +136,8 @@ public static String getValue(AccessibilityRole role) {
return "android.widget.SpinButton";
case SWITCH:
return "android.widget.Switch";
case LIST:
return "android.widget.ListView";
Copy link
Contributor

@blavalla blavalla Jun 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to make this "android.widget.AbsListView.class" to match Talkback's internal implementation here:

https://github.com/google/talkback/blob/f5d564fdc915a74d8cde4868608f307de9ccf957/utils/src/main/java/com/google/android/accessibility/utils/Role.java#L380

case NONE:
case LINK:
case SUMMARY:
Expand Down
1 change: 1 addition & 0 deletions packages/rn-tester/js/examples/FlatList/FlatListExample.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ class FlatListExample extends React.PureComponent<Props, State> {
getItemLayout={
this.state.fixedHeight ? this._getItemLayout : undefined
}
accessibilityRole="list"
horizontal={this.state.horizontal}
inverted={this.state.inverted}
key={
Expand Down
1 change: 1 addition & 0 deletions packages/rn-tester/js/examples/SectionList/SectionListExample.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@ function SectionListExample(Props: {...}): React.Element<typeof RNTesterPage> {
ItemSeparatorComponent={info => (
<CustomSeparatorComponent {...info} text="ITEM SEPARATOR" />
)}
accessibilityRole="list"
debug={debug}
inverted={inverted}
disableVirtualization={!virtualized}
Expand Down
1 change: 1 addition & 0 deletions packages/rn-tester/js/examples/SectionList/SectionListExamples.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@ const SectionListExampleWithForwardedRef = React.forwardRef(
<SectionList
ref={ref}
testID="section_list"
accessibilityRole="list"
sections={DATA}
keyExtractor={(item, index) => item + index}
style={styles.list}
Expand Down