Skip to content

Conversation

@sahrens
Copy link
Contributor

@sahrens sahrens commented Sep 1, 2015

The Animated module exposes a lot of functionality, including internal classes. This diff extracts properties and classes from modules and renders them recursively.

This also adds Animated to the autogen docs now that they more capable, although it needs way more docblocks and such which will come later.

Before:
screen shot 2015-09-01 at 12 57 08 pm

After:
screen shot 2015-09-01 at 12 38 12 pm

@sahrens
Copy link
Contributor Author

sahrens commented Sep 1, 2015

@vjeux, can you do a quick review?

@sahrens
Copy link
Contributor Author

sahrens commented Sep 1, 2015

Oops, looks like an extra diff got in there - let me get rid of that.

@sahrens
Copy link
Contributor Author

sahrens commented Sep 1, 2015

Also cc @hansonw - would be nice to bring these changes into codex and wrap the whole thing into an open source npm module...

@sahrens
Copy link
Contributor Author

sahrens commented Sep 1, 2015

Fixed a bug...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have one extra () around map

@vjeux
Copy link
Contributor

vjeux commented Sep 1, 2015

Sounds good to me

@brentvatne
Copy link
Collaborator

Looks great @sahrens! 🎉

The `Animated` module exposes a lot of functionality, including internal
classes. This diff extracts properties and classes from modules and renders them
recursively.

This also adds `Animated` to the autogen docs now that they more capable,
although it needs way more docblocks and such which will come later.
sahrens added a commit that referenced this pull request Sep 1, 2015
[Docs] Expand API parsing and rendering
@sahrens sahrens merged commit 2fc8ca0 into facebook:master Sep 1, 2015
@sahrens sahrens deleted the animatedDocGen branch September 1, 2015 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants