Website improvements #223
Merged
Website improvements #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Well, I set the size wrong for that breakpoint image AND I forgot about retina displays, so it's blurry... |
Contributor
|
Does this fix the horizontal scroll on mobile? |
Member
Author
|
Almost, need to also set overflow: auto on .prism (code). I'm going to drop the image resizing and just optim them and add the prism fix. |
Contributor
|
(y) |
zpao
force-pushed
the
website-improvements
branch
from
5ef0368 to
4c65579
Compare
Member
Author
|
Alright, all better.
|
This is a quick fix for "responsive" views. It's not perfect but it's less bad.
This should fix the remaining horizontal scrolls on mobile.
This looks *less bad* than it currently does but it's still pretty clowny.
zpao
force-pushed
the
website-improvements
branch
from
4c65579 to
35fa5aa
Compare
mganandraj
added a commit
to mganandraj/react-native
that referenced
this pull request
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#content(feels really bad on mobile)