Skip to content

Conversation

@cxfeng1-zz
Copy link
Contributor

Now RCTAnimationExperimentalManager is not working on 32bit devices.

NSValue *fromValue = [view.layer.presentationLayer valueForKeyPath:keypath];
CGFloat fromFields[count];
[fromValue getValue:fromFields];

If the fromValue is kind of double value which needs two bytes in 32bit device and the count is 1, the fromFileds array will go wrong.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 23, 2015
@brentvatne
Copy link
Collaborator

This sounds good to me, however AnimationExperimental is deprecated. @vjeux do we want to accept patches for this?

@vjeux
Copy link
Contributor

vjeux commented Jun 23, 2015

@brentvatne doesn't hurt while there's no other solution

@brentvatne
Copy link
Collaborator

Should be an easy review and import for @nicklockwood

@cxfeng1-zz cxfeng1-zz changed the title Fix animation but in 32bit when fromValue is double. Fix animation bug in 32bit when fromValue is double. Jun 24, 2015
@frantic frantic closed this in b09f3ea Jun 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants