iOS native module rejections are not `instanceof Error`

[vonovak]

Description

Promise rejections coming from native modules on iOS are not instanceof Error. This is not in line with Android, and with what I believe is expected.

To reproduce, build for new arch on ios and run

Linking.openURL('sfslfjsd').catch(e => {
	console.warn({isInstanceOf: e instanceof Error});
});

I expect to see true but instead it's false

Steps to reproduce

npx react-native init bugrepro
RCT_NEW_ARCH_ENABLED=1 pod install

add

Linking.openURL('sfslfjsd').catch(e => {
	console.warn({isInstanceOf: e instanceof Error});
});

React Native Version

0.73.0

Affected Platforms

Runtime - iOS

Areas

TurboModule - The New Native Module System

Output of npx react-native info

System:
  OS: macOS 14.2
  CPU: (10) arm64 Apple M1 Max
  Memory: 101.94 MB / 64.00 GB
  Shell:
    version: 5.2.15
    path: /opt/homebrew/bin/bash
Binaries:
  Node:
    version: 21.2.0
    path: /opt/homebrew/bin/node
  Yarn:
    version: 1.22.19
    path: /opt/homebrew/bin/yarn
  npm:
    version: 10.2.3
    path: /opt/homebrew/bin/npm
  Watchman:
    version: 2023.09.04.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.12.1
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.0
      - iOS 17.0
      - macOS 14.0
      - tvOS 17.0
      - watchOS 10.0
  Android SDK:
    API Levels:
      - "24"
      - "28"
      - "29"
      - "30"
      - "31"
      - "32"
      - "33"
      - "33"
      - "33"
      - "34"
    Build Tools:
      - 28.0.3
      - 29.0.2
      - 30.0.2
      - 30.0.3
      - 31.0.0
      - 32.0.0
      - 33.0.0
      - 33.0.1
      - 34.0.0
    System Images:
      - android-19 | Google APIs ARM EABI v7a
      - android-21 | Google APIs ARM 64 v8a
      - android-22 | Google APIs ARM 64 v8a
      - android-23 | Intel x86 Atom
      - android-23 | Google APIs ARM 64 v8a
      - android-23 | Google APIs ARM EABI v7a
      - android-23 | Google APIs Intel x86 Atom_64
      - android-24 | ARM 64 v8a
      - android-24 | Google APIs ARM 64 v8a
      - android-25 | Google APIs ARM 64 v8a
      - android-28 | ARM 64 v8a
      - android-29 | Google APIs ARM 64 v8a
      - android-30 | Google Play ARM 64 v8a
      - android-31 | ARM 64 v8a
      - android-31 | Google Play ARM 64 v8a
      - android-32 | Google Play ARM 64 v8a
      - android-34 | Google APIs ARM 64 v8a
    Android NDK: 22.1.7171670
IDEs:
  Android Studio: Not Found
  Xcode:
    version: 15.0.1/15A507
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.7
    path: /usr/bin/javac
  Ruby:
    version: 2.7.8
    path: /opt/homebrew/opt/ruby@2.7/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.73.0
    wanted: 0.73.0
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: true

Stacktrace or Logs

not applicable

Reproducer

https://github.com/vonovak/bugrepro

Screenshots and Videos

No response

[kelset]

cc @cipolleschi - sounds like it's your area?

[cipolleschi]

Thanks for reporting this. We have a workstream this half to fix these inconsistencies, I'll put the issue in those tasks. We will try to address all of them before 0.74.

[zhongwuzw]

@cipolleschi Hi, can you help review this PR #41955? it should fix this issue.

[cipolleschi]

@zhongwuzw reviewed!