-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Closed
Labels
Platform: WindowsBuilding on Windows.Building on Windows.Tech: CodegenRelated to react-native-codegenRelated to react-native-codegenType: New ArchitectureIssues and PRs related to new architecture (Fabric/Turbo Modules)Issues and PRs related to new architecture (Fabric/Turbo Modules)
Description
Description
The following line is wrong, because glob expects patterns with / separators, even on Windows; but when the codegen is executed on Windows the file will contain \ separators, causing that query not matching anything:
react-native/packages/react-native-codegen/src/cli/combine/combine-js-to-schema-cli.js
Line 25 in ca0d565
| .sync(`${file}/**/*.{js,ts,tsx}`, { |
Changing that line into:
.sync(`${file.replace(/\\/g, '/')}/**/*.{js,ts,tsx}`, {fixes the issue (well, I verified that codegen then matches expected files there, but it still does not generate expected outputs, so I am still looking for other issues down the line).
React Native Version
0.71.4
Output of npx react-native info
N/A
Steps to reproduce
N/A
Snack, code example, screenshot, or link to a repository
N/A
Metadata
Metadata
Assignees
Labels
Platform: WindowsBuilding on Windows.Building on Windows.Tech: CodegenRelated to react-native-codegenRelated to react-native-codegenType: New ArchitectureIssues and PRs related to new architecture (Fabric/Turbo Modules)Issues and PRs related to new architecture (Fabric/Turbo Modules)