Skip to content

Conversation

@cipolleschi
Copy link
Contributor

Add notes to help Mac M1 users troubleshoot common problems with Cocoapods.

@netlify
Copy link

netlify bot commented Feb 21, 2022

✔️ Deploy Preview for react-native ready!

🔨 Explore the source changes: f3cb438

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/6216453e2d0220000781c9b2

😎 Browse the preview: https://deploy-preview-2974--react-native.netlify.app

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @cipolleschi, thank you for the update on that! 👍

Can you extract the M1 note to the partial and use it as component on the pages to reduce the duplations and reduce the maintenance in the future? You can see how use partials in here:

Also the Podfile for the new architecture has been just updated in #2973, and this PR seems to revert the changes, I'm not sure if this is intentional.

@cipolleschi
Copy link
Contributor Author

Can you extract the M1 note to the partial and use it as component on the pages to reduce the duplations and reduce the maintenance in the future?

On it!

Ale the Podfile for the new architecture has been just updated in #2973, and this PR seems to revert the changes, I'm not sure if this is intentionally.

Ouch, my bad! I'll rebase immediately.

Comment on lines 1 to 10
<details>
<summary>Note for Mac M1 users</summary>
Mac M1 architecture is not directly compatible with Cocoapods. If you encounter issues when installing pods, you can solve it by running:

- `sudo arch -x86_64 gem install ffi`
- `arch -x86_64 pod install`

These commands install the `ffi` package, to load dynamically-linked libraries and let you run the `pod install` properly, and runs `pod install` with the proper architecture.

</details>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use an info admonitions here:
https://docusaurus.io/docs/next/markdown-features/admonitions instead of the <details> block

Copy link
Collaborator

@Simek Simek Feb 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was my first, preferred approach to the formatting here too, but it looks like summary+details looks quite nice in there, plus I like the collapsible part, this information affects only low percentage of the RN users.

Ohh, I want to provide the screenshot from the preview, but it has already been updated. 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome let's stick to this then 👍

Copy link
Contributor

@cortinico cortinico Feb 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cipolleschi could you revert to use <details>/<summary> (sorry for the long rtt)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cortinico: done! @Simek: reverted. If it's ok, we can merge it! :D
Thank you a lot for the review.

Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting to unblock 👍 minor nit but we're good to go

@cortinico cortinico merged commit 36d1d72 into facebook:main Feb 23, 2022
sunnylqm added a commit to reactnativecn/react-native-website that referenced this pull request Mar 26, 2022
* Generate 0.67 version of the docs (facebook#2926)

* version 0.67

* Revert "version 0.67"

This reverts commit f4896ac.

* updated v0.67 docs cut

* blogpost for 0.67 (facebook#2933)

* add Lorenzo

* Facebook -> Meta

* 067 blogpost

* add highlights and truncate

* tweak

* Update website/blog/2022-01-19-version-067.md

* Update website/blog/2022-01-19-version-067.md

Co-authored-by: Eli White <[email protected]>

* Move Hermes 0.10 issue callout to acknowledgements

* Link the wiki

Co-authored-by: Luna <[email protected]>
Co-authored-by: Eli White <[email protected]>

* blogpost: React Native - H2 2021 Recap (facebook#2937)

Co-authored-by: Luna <[email protected]>

* Fix typo in H2 blog post: next year / half -> numbers (facebook#2938)

* Use numbers for the time

* Bump nanoid from 3.1.30 to 3.2.0 (facebook#2939)

Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.30 to 3.2.0.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.1.30...3.2.0)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* remove text in running on device (facebook#2943)

* remove text on docs running-on-device (facebook#2944)

* Fix small grammatical error (facebook#2942)

* update copyright on website (facebook#2940)

Co-authored-by: luism3861 <[email protected]>

* Fix flexShrink default value in Layout Props docs (facebook#2945)

* update website font, misc UI tweaks (facebook#2947)

* Fix the guide to the deprecated OpenJDK installation command. (facebook#2817)

* Add function based components example for Flat list optimisation (facebook#2955)

* Update typo in render-pipeline.md (facebook#2951)

* Update typo in tutorial.md (facebook#2946)

* Add an extra command to the troubleshooting guide for typescript template (facebook#2954)

Co-authored-by: Nicola Corti <[email protected]>

* (Image) Fix documentation for onLoad event. (facebook#2964)

* - (Image) Fix documentation for onLoad event.

* - (Image) Prettier.

* Update image.md (facebook#2965)

* Bump follow-redirects from 1.14.7 to 1.14.8 (facebook#2966)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixed a typo in Linking page. (facebook#2968)

AndroidManifext.xml should be AndroidManifest.xml

* 📚 Guide: Getting Started with The New Architecture (a.k.a. the Playbook) (facebook#2879)

* Initial Draft of the New Architecture Playbook

* Fix c++ codeblocks not rendering correctly

* Fix Android.mk containing wrong wildcards

* Remove Markdown exports artifacts

* Fix missing parenthesis in section header

* Renamed section header as it was incomplete

* Removed canCreateTurboModule as it was not used

* Fix indententation and add imports to MyComponentsRegistry.java

* Add missing import for MyComponentsRegistry.h

* Fix the broken table

* s/two/three arguments

* Fix comments inside podfile

* split The New Architecture guide into few pages (facebook#2882)

* Fix wrong import for ./RNTMyNativeViewNativeComponent

* Fix import for codegenNativeCommands

* Add a banner for TypeScript support

* Do not sound prescriptive with 'you will be using flow'

* React concurrent mode -> React 18

* Add a banner on homepage about the number of manual steps

* Fix typo on Enabling TurboModule section title

Co-authored-by: Johny Urgiles <[email protected]>

* code formatting, admonitions and small tweaks (facebook#2922)

Co-authored-by: Nicola Corti <[email protected]>

* Use descriptive component names and fix use of ref (facebook#2935)

* Use descriptive component names and fix use of ref

* Remove ambiguity from migrating .measure* example

* Playbook => Guide

* Use implicit dependency substitution for the Gradle Plugin

* Specify reactRoot and codegenDir in the App setup

* Add a patch for configureNdkBuild not depending on preBuild

* Add the getTurboModule method

* Copy the warning banner on all the pages

* Update pod install to specify RCT_NEW_ARCH_ENABLED

* HermesExecutorFactory header lives inside reacthermes/ and not React/

* Fix broken jsExecutorFactoryForBridge iOS

* Bump used nightly version to 0.0.0-20220201-2008-79975d146

* Clarify the react-native-codegen version to use

* Suggest to use :app:externalNativeBuildDebug instead of Release

* Put LOCAL_SHARED_LIBRARIES on Android.mk on separate lines

* Update docs/new-architecture-app-renderer-ios.md

Co-authored-by: Bartosz Kaszubowski <[email protected]>

* Remove unnecessary duplicated `pod install`

Co-authored-by: Bartosz Kaszubowski <[email protected]>

* Setup a New Architecture Troubleshooting page

* Fix lint failures on troubleshooting section

Co-authored-by: Bartosz Kaszubowski <[email protected]>
Co-authored-by: Johny Urgiles <[email protected]>
Co-authored-by: Samuel Susla <[email protected]>

* fix(ios): update Fabric in Podfile instructions (facebook#2973)

* fix(ios): update Fabric in Podfile instructions

* move fabric_enabled comment closer to the property

* 📚 Add instruction for M1 users to work with Cocoapods (facebook#2974)

* Update Android SDK version to 30 (facebook#2975)

* Adding Explain Like I'm 5 video to the home page (facebook#2971)

* Adding ELI5 video to the home page

* Remove unused VideoContainer function

* Combining Video and Talk sections

Co-authored-by: Dmitry Vinnik <[email protected]>

* Updated expired link in docs/security (facebook#2972)

* Updated link colors to meet WCAG color contrast guidelines. (facebook#2976)

* Bump prismjs from 1.25.0 to 1.27.0 (facebook#2978)

Bumps [prismjs](https://github.com/PrismJS/prism) from 1.25.0 to 1.27.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](PrismJS/prism@v1.25.0...v1.27.0)

---
updated-dependencies:
- dependency-name: prismjs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: spelling error mudule -> module (facebook#2979)

* Update migration guide feedback link to the working group (facebook#2983)

* Add TOC sections for the 'Render, Commit, and Mount' page (facebook#2985)

* Adding Social Banner in Support of Ukraine  (facebook#2986)

* fix layout resizing when page includes wide code block (facebook#2980)

* docs: Moving to use Announcement Banner for the Support Ukraine Initiative (facebook#2988)

* Fix deeplink to react-host-components-or-host-components in Glossary (facebook#2992)

* Clarify intended audience for architecture overview (facebook#2995)

* changed android_hyphenation for 0.67+ (facebook#2982)

* Add missing `normal` enum for Hyphenation (facebook#3002)

* add ToC headers for phases on Render Pipeline page (facebook#2997)

* Moving Release Wiki to react-native-website (facebook#2961)

Co-authored-by: Simek <[email protected]>

* Update discrete update threading model diagram (facebook#2999)

* move Fabric warning to partial, use admonition (facebook#2998)

* Clarify the Configure Codegen in your Gradle File section (facebook#2993)

Co-authored-by: Bartosz Kaszubowski <[email protected]>

* Unversion Architecture docs (facebook#3000)

Co-authored-by: Bartosz Kaszubowski <[email protected]>

* refactor(getting-started): path to sdk binaries (facebook#2991)

* bump lint stack, include `website` files in check (facebook#3004)

* Add table of contents and encourage people to leave feedback in working group in Architecture Overview intro (facebook#2996)

* Clarify intended audience for architecture overview
* Fix broken links

* Blogpost: An update on the New Architecture Rollout (facebook#3009)

Co-authored-by: Bartosz Kaszubowski <[email protected]>
Co-authored-by: Lorenzo Sciandra <[email protected]>

* Use bundler to pod install (facebook#3011)

* Use placeholders instead of hardcoded strings (facebook#3015)

* Use @flow annotation and fix syntax (facebook#3016)

* Improve documentation about JS Specs (facebook#3017)

* Use more specific dependency React-Core (facebook#3020)

* distinguish windows from mac keytool instructions (facebook#3019)

Co-authored-by: Bartosz Kaszubowski <[email protected]>

* spelling fix (facebook#3021)

* Rename _bridge into bridge (facebook#3013)

* Use empty dicts instead of nil (facebook#3014)

* 📚 Rename JSCExecutorFactory into HermesExecutorFactory (facebook#3012)

* fix codegenNativeCommands section example (facebook#3024)

Co-authored-by: Piotr Trocki <[email protected]>

* [sync-api] Replace deprecated String.prototype.substr() (facebook#3025)

* Add kotlin sample code in "Integration with an Android Fragment" documentation (facebook#2977)

Co-authored-by: Andrei Shikov <[email protected]>
Co-authored-by: Nicola Corti <[email protected]>
Co-authored-by: Simek <[email protected]>

* small custom CSS fixes and tweaks (facebook#3026)

* Update references from Java to Java/Kotlin in the body of the article (facebook#3028)

Co-authored-by: Bartosz Kaszubowski <[email protected]>

* update project structure in Readme (facebook#3031)

Co-authored-by: Lorenzo Sciandra <[email protected]>
Co-authored-by: Luna <[email protected]>
Co-authored-by: Eli White <[email protected]>
Co-authored-by: Nicola Corti <[email protected]>
Co-authored-by: Luna <[email protected]>
Co-authored-by: Sota <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Luis Medina Huerta <[email protected]>
Co-authored-by: Palash Shrivastava <[email protected]>
Co-authored-by: Michael Evans <[email protected]>
Co-authored-by: luism3861 <[email protected]>
Co-authored-by: jzxchiang1 <[email protected]>
Co-authored-by: Bartosz Kaszubowski <[email protected]>
Co-authored-by: 1natsu <[email protected]>
Co-authored-by: DIBYAJYOTI MISHRA <[email protected]>
Co-authored-by: Jiovanna Manriquez <[email protected]>
Co-authored-by: markbell2410 <[email protected]>
Co-authored-by: Nicola Corti <[email protected]>
Co-authored-by: Erick Maeda Lopes <[email protected]>
Co-authored-by: Kavanaugh Latiolais <[email protected]>
Co-authored-by: hj <[email protected]>
Co-authored-by: Johny Urgiles <[email protected]>
Co-authored-by: Samuel Susla <[email protected]>
Co-authored-by: Tommy Nguyen <[email protected]>
Co-authored-by: Riccardo <[email protected]>
Co-authored-by: Kid <[email protected]>
Co-authored-by: Dmitry Vinnik <[email protected]>
Co-authored-by: Dmitry Vinnik <[email protected]>
Co-authored-by: Vishwa Gaurav <[email protected]>
Co-authored-by: blavalla <[email protected]>
Co-authored-by: RayKay91 <[email protected]>
Co-authored-by: zegermouw <[email protected]>
Co-authored-by: Nicolas <[email protected]>
Co-authored-by: Sébastien Lorber <[email protected]>
Co-authored-by: Henry Hobhouse <[email protected]>
Co-authored-by: Samuel Susla <[email protected]>
Co-authored-by: Danilo Bürger <[email protected]>
Co-authored-by: Riccardo <[email protected]>
Co-authored-by: Fernando Cervera <[email protected]>
Co-authored-by: Rajesh Sharma <[email protected]>
Co-authored-by: troZee <[email protected]>
Co-authored-by: Piotr Trocki <[email protected]>
Co-authored-by: CommanderRoot <[email protected]>
Co-authored-by: David Vacca <[email protected]>
Co-authored-by: Andrei Shikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants