Skip to content

fix: bump jest-haste-map #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: bump jest-haste-map #432

wants to merge 1 commit into from

Conversation

@SimenB
Copy link
Contributor

@SimenB SimenB commented Jul 16, 2019

Summary

This includes jestjs/jest#8558

Test plan

Dunno... Green CI? 😀

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2019
SimenB
SimenB commented Jul 16, 2019
View reviewed changes
package.json
"debug": "^2.2.0",
"eslint": "5.1.0",
"eslint-config-fb-strict": "22.1.0",
"eslint-config-fb-strict": "24.0.0",
Copy link
Contributor Author

@SimenB SimenB Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly better...

Before:
image

After:
image

SimenB
SimenB commented Jul 16, 2019
View reviewed changes
scripts/build.js
} else {
const transformed = prettier.format(babel.transformFileSync(file, {}).code, {
parser: 'babylon',
parser: 'babel',
Copy link
Contributor Author

@SimenB SimenB Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@SimenB SimenB mentioned this pull request Jul 16, 2019
Merged
@codecov-io
Copy link

codecov-io commented Jul 16, 2019

Codecov Report

Merging #432 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #432   +/-   ##
=======================================
  Coverage   84.81%   84.81%           
=======================================
  Files         192      192           
  Lines        6296     6296           
  Branches      992      992           
=======================================
  Hits         5340     5340           
  Misses        845      845           
  Partials      111      111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f9cdb7...f89ea68. Read the comment docs.

SimenB
SimenB commented Jul 16, 2019
View reviewed changes
package.json
"istanbul-api": "^1.1.0",
"istanbul-lib-coverage": "^1.0.0",
"jest": "^24.7.1",
"jest": "^24.8.0",
Copy link
Contributor Author

@SimenB SimenB Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not

@cpojer
Copy link
Contributor

cpojer commented Aug 5, 2019

Unfortunately we can't land this as is. Metro is tied together with RN at FB. I'll ask @scotthovestadt to do an update internally.

@cpojer cpojer closed this Aug 5, 2019
@SimenB SimenB deleted the up-jets-haste branch August 10, 2019 09:26
@SimenB SimenB mentioned this pull request Aug 16, 2019
Closed
@mikehardy
Copy link
Contributor

mikehardy commented Aug 16, 2019

@cpojer I would request a bump to 24.9.0 now but it appears that a PR for that would be closed based on your comment. Can I comment-request a bump to 24.9.0 then :-)

Without it, current node v12 startup time for react-native start is like 2.5 minutes vs 12 seconds so it's a dev experience issue. Unsure on correctness etc but as a minor it shouldn't impact things negatively to bump it (hopefully not famous last words). Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.81%. Comparing base (8f9cdb7) to head (f89ea68).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #432   +/-   ##
=======================================
  Coverage   84.81%   84.81%           
=======================================
  Files         192      192           
  Lines        6296     6296           
  Branches      992      992           
=======================================
  Hits         5340     5340           
  Misses        845      845           
  Partials      111      111

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SimenB
Copy link
Contributor Author

SimenB commented Oct 24, 2025

nice necropost codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SimenB @codecov-io @cpojer @mikehardy @codecov-commenter @facebook-github-bot