Skip to content

Conversation

@huntie
Copy link
Member

@huntie huntie commented Jul 7, 2023

Summary:
Resolves #1026.

Changelog: [Feature] Widen config search paths to include metro.config.cjs

Differential Revision: D47290079

Summary:
Resolves facebook#1026, resolves facebook#916.

Changelog: **[Feature]** Widen config search paths to include `metro.config.cjs`

Differential Revision: D47290079

fbshipit-source-id: d50c61f08580a04ad2de57092a0c77c5c5b0f22a
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Jul 7, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47290079

@oblador
Copy link

oblador commented Jul 7, 2023

Thanks for a quick fix!

resolves #916

Are you sure this is true? Doesn't seem to address TS in the config

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6922933.

huntie added a commit to huntie/metro that referenced this pull request Aug 7, 2023
Summary:
Pull Request resolved: facebook#1027

Resolves facebook#1026.

Changelog: **[Feature]** Widen config search paths to include `metro.config.cjs`

Reviewed By: robhogan

Differential Revision: D47290079

fbshipit-source-id: 3e46c954a1e1451558b14ed4558fede5f00200dd
huntie added a commit that referenced this pull request Aug 7, 2023
Summary:
Pull Request resolved: #1027

Resolves #1026.

Changelog: **[Feature]** Widen config search paths to include `metro.config.cjs`

Reviewed By: robhogan

Differential Revision: D47290079

fbshipit-source-id: 3e46c954a1e1451558b14ed4558fede5f00200dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ESM project support broken in 0.76/RN 0.72

3 participants