Use original Error.prototype.toString for formating Error.stack #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Use the original Error.prototype.toString (as defined in ES2023 20.5.3.4) to format Error.stack. Also make sure a runaway recursion while formatting the stack does not bring the VM down. Finally, try to scrape any exceptions raised while formatting the stack trace so the user can get some information that an error happened (this last item leads to poor developer experience when there is an infinite recursion while formatting the stack). Reviewed By: newobj Differential Revision: D44258504 fbshipit-source-id: 772ae8225bfb1128cc6abadea75f5163714e70a5
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a cherry-pick of f2f1a2e onto
rn/0.71-stableUse the original Error.prototype.toString (as defined in ES2023 20.5.3.4) to format Error.stack. Also make sure a runaway recursion while formatting the stack does not bring the VM down. Finally, try to scrape any exceptions raised while formatting the stack trace so the user can get some information that an error happened (this last item leads to poor developer experience when there is an infinite recursion while formatting the stack).
Reviewed By: newobj
Differential Revision: D44258504
fbshipit-source-id: 772ae8225bfb1128cc6abadea75f5163714e70a5
Summary
There was a cp conflict where
test/hermes/regress-error-capture-stack-trace-native-constructor.jsdoesn't exist inrn/0.71-stable.I wasn't sure how to run the tests to ensure this doesn't break
Motivation is: reactwg/react-native-releases#69