Fix table size for android

[karol-bisztyga]

Description

Hi!
I wanted to fix a build of folly on Android.

Trying to use folly's MPMCQueue on Android triggers the following error:

{xxx}/rnfbjni/android/app/build/third-party-ndk/folly/folly/Subprocess.cpp:542:19: error: use of undeclared identifier 'getdtablesize'; did you mean 'getpagesize'?

where {xxx} is a local path on my machine.

Here is a branch of my project that reproduces the problem(I've already fixed it by patching folly so you can see what patch has to be removed in order to make it fail here).

From the man page for getdtablesize:

SVr4, 4.4BSD (the getdtablesize() function first appeared in 4.2BSD). It is not specified in POSIX.1-2001; portable applications should employ sysconf(_SC_OPEN_MAX) instead of this call.

Related issues:

#1279
#918 - probably, I cannot see bug details.

[facebook-github-bot]

Hi @karol-bisztyga!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[yfeldblum]

Any particular reason to keep the call to getdtablesize on non-Android platforms, seeing as it's less portable?

[karol-bisztyga]

I've never really tested it on all other platforms - I just checked android and it works on it. To change it for every platform I should check every one of them, don't you think?

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[facebook-github-bot]

@yfeldblum has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@yfeldblum merged this pull request in beded0e.