fix(react-scripts): proactively append to .gitignore during generation #8028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmuenzenmeyer
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
mrmckeb
approved these changes
Dec 1, 2019
|
Thanks for the approval. Understand timing is sometimes tough, but as far as I know not including this will cause a bug in 3.3.0 |
|
@mrmckeb @iansu @ianschmitz @petetnt hoping this can get looked at again soon - it's an active 3.3.0 bug |
|
@bmuenzenmeyer This issue should be very low impact right now, but I appreciate it needs to be dealt with. @ianschmitz can you take a look at this one? |
mrmckeb
approved these changes
Dec 18, 2019
|
Thanks @bmuenzenmeyer, we'll get this into v3.3.1 - which should be out in the next week or two. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #7892
Proactively append to
.gitignoreduring generation instead relying on atry/catchAs #7892 illustrates, relying on the
EEXISTSerror is not reliable after the[email protected]upgrade. This fact was confirmed by thefs-extrateam when I opened an an issue with them.The solution is to check whether or not
.gitignoreexists in the current repo and proactively appendgitignoreto it, rather than rely on the try catch logic to sniff forEEXISTS/dest already existserrors fromfs-extraTesting
I attempted to test this:
foo.gitignoreinto it with contents.yarn create-react-app foo --template typescriptThis succeeds, but gives me warnings about not having a version that supports
template. If I do not supply a template, the CLI tells me none was applied.When I run this without the
templatearg, I get a reverse error message, stating no template was applied. Having maintained a fork for a long time, I know not to rely on the npm scriptcreate-react-appas gospel for a real generation. I also know that this new template functionality is still in progress - so I am guessing it's just a quick of this being a bit in-flight.I think a better approach may be to add a check for this proper appending via CI, but I wanted to get this out here first. I'd also state that the code is pretty darn simple, mostly co-opted from the existing try / catch, and that I don't see any
.gitignorecoverage currently in the e2e tests. Perhaps a visual review is okay without a formal test - but I'll leave that to the maintainers to decide.