Skip to content

Validation for multiple arguments if specified for create-react-app #6080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2019
Merged

Validation for multiple arguments if specified for create-react-app #6080

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2eef4b
validate multiple arguments if provided :rocket:
jamesgeorge007 Dec 21, 2018
e11b675
minor code restructure :construction:
jamesgeorge007 Jan 26, 2019
945be6c
Update logic and style
mrmckeb Feb 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions packages/create-react-app/createReactApp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,11 +143,24 @@ if (program.info) {
.then(console.log);
}

if (typeof projectName === 'undefined') {
console.error('Please specify the project directory:');
console.log(
` ${chalk.cyan(program.name())} ${chalk.green('<project-directory>')}`
);
const hasMultipleProjectNameArgs =
process.argv[3] && !process.argv[3].startsWith('-');
if (typeof projectName === 'undefined' || hasMultipleProjectNameArgs) {
console.log();
if (hasMultipleProjectNameArgs) {
console.error(
`You have provided more than one argument for ${chalk.green(
'<project-directory>'
)}.`
);
console.log();
console.log('Please specify only one project directory, without spaces.');
} else {
console.error('Please specify the project directory:');
console.log(
` ${chalk.cyan(program.name())} ${chalk.green('<project-directory>')}`
);
}
console.log();
console.log('For example:');
console.log(` ${chalk.cyan(program.name())} ${chalk.green('my-react-app')}`);
Expand Down