webpack no need for ident if using complex options anymore
#2430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `v2.2.1` of webpack the need for `ident` for complex options is no longer required. See https://webpack.js.org/guides/migrating/#complex-options
|
Can confirm 👍 |
Contributor
|
Thanks! |
This was referenced Jun 28, 2017
Merged
Contributor
|
Seems like this was necessary after all :P |
Contributor
Author
|
Ah. Sorry about that @gaearon . One of the issues with webpack supporting legacy loader configs :( |
Contributor
|
No worries! I'd appreciate if you could dig into why this is still necessary and breaks in this weird way. Maybe there's a bug in one of those packages? |
romaindso
pushed a commit
to romaindso/create-react-app
that referenced
this pull request
Jul 10, 2017
…k#2430) Since `v2.2.1` of webpack the need for `ident` for complex options is no longer required. See https://webpack.js.org/guides/migrating/#complex-options
wmonk
referenced
this pull request
in wmonk/create-react-app-typescript
Aug 7, 2017
Since `v2.2.1` of webpack the need for `ident` for complex options is no longer required. See https://webpack.js.org/guides/migrating/#complex-options
morgs32
pushed a commit
to BrickworkSoftware/create-react-app
that referenced
this pull request
Sep 1, 2017
…k#2430) Since `v2.2.1` of webpack the need for `ident` for complex options is no longer required. See https://webpack.js.org/guides/migrating/#complex-options
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
v2.2.1of Webpack, the need foridentfor complex options is no longer required. Seehttps://webpack.js.org/guides/migrating/#complex-options
Steps ran to check if
postcss-loaderand its plugins still work.npm start.App.css.postcss-flexbugs-fixes&autoprefixerwork. See screenshot.Then checked build version
npm run buildserve -s build