Add restricted globals package

[sidoshi]

Add restricted globals in a separate package.

[gaearon]

Shouldn't we have it in top level gitignore?

[gaearon]

Let's use this example:

function printStatus(stats) {
  console.log(status);
}

[gaearon]

Please add use strict and standard license header.

[gaearon]

Let's make it 1.0

[gaearon]

Let's remove the lock here.

[gaearon]

Let's call it confusing-browser-globals.

[gaearon]

Let's instead test that it contains event as a sanity check.

[gaearon]

Let's make sure this test runs on our CI.

[sidoshi]

Not sure how to do this. 😕

[gaearon]

Need to update this too.

[gaearon]

and this

[gaearon]

Two spaces please.

[gaearon]

Please use two spaces for indentation.

[gaearon]

Please use semicolons.

[gaearon]

Nit: please use Array.isArray() instead.

[gaearon]

The title is still old.

[sidoshi]

Sorry, UPDATING.

[gaearon]

Actually, would you mind changing this to use Jest for testing?

We don't use it in integration tests because of some obscure jsdom issue but it would be great to dogfood it in other places.

[sidoshi]

Okay, but I don't know how to work with CI tests.

[gaearon]

I just mean that instead of calling mocha you could call jest (and add it to dependencies).

And replace assertions with Jest syntax:

expect(Array.isArray(globals)).toBe(true);