Skip to content

update readme with fix from #1939 #2114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 12, 2017
Merged

update readme with fix from #1939 #2114

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
80a10bf
update readme with fix from https://github.com/facebookincubator/crea…
kellyrmilligan May 10, 2017
d406724
update with better globbing
kellyrmilligan May 10, 2017
24f3fcd
added note
kellyrmilligan May 10, 2017
b3ce3f7
updating with a note and reverting previous changes
kellyrmilligan May 11, 2017
3dc41f0
how about this?
kellyrmilligan May 11, 2017
8eaaad3
refactor
kellyrmilligan May 11, 2017
1baf645
added note about new files back in after verifying locally
kellyrmilligan May 11, 2017
df67823
spaces back in, sorry was my editor!
kellyrmilligan May 11, 2017
32653a0
removed note about new files :)
kellyrmilligan May 11, 2017
2b85cfd
added bullet about new files issue currently open on node-sass
kellyrmilligan May 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/react-scripts/template/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ To configure the syntax highlighting in your favorite text editor, head to the [

## Displaying Lint Output in the Editor

>Note: this feature is available with `[email protected]` and higher.
Copy link
Contributor

@gaearon gaearon May 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace is significant in markdown. Please leave those two spaces in, they are causing the line to break. They were intentional.

>Note: this feature is available with `[email protected]` and higher.
>It also only works with npm 3 or higher.

Some editors, including Sublime Text, Atom, and Visual Studio Code, provide plugins for ESLint.
Expand Down Expand Up @@ -406,7 +406,7 @@ Then in `package.json`, add the following lines to `scripts`:
```diff
"scripts": {
+ "build-css": "node-sass src/ -o src/",
+ "watch-css": "npm run build-css && node-sass src/ -o src/ --watch --recursive",
+ "watch-css": "npm run build-css && node-sass src/*.scss -o src/ --watch --recursive",
Copy link
Contributor

@Timer Timer May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be src/**/*.scss?
Also, what about sass files? Aren't both extensions supported?

Copy link
Contributor Author

@kellyrmilligan kellyrmilligan May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor Author

@kellyrmilligan kellyrmilligan May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, updating. I coudn't find anything at first in the readme of node-sass but looking through the code of the cli, yeah normal globbing is supported. updating. .sass files are supported, but I think for a readme this should suffice no?

Copy link
Contributor

@Timer Timer May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most likely, yeah! I just want to make sure it's noted.

Thanks!

Copy link
Contributor Author

@kellyrmilligan kellyrmilligan May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted 👍

"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test --env=jsdom",
Expand All @@ -431,7 +431,7 @@ Then we can change `start` and `build` scripts to include the CSS preprocessor c
```diff
"scripts": {
"build-css": "node-sass src/ -o src/",
"watch-css": "npm run build-css && node-sass src/ -o src/ --watch --recursive",
"watch-css": "npm run build-css && node-sass src/*.scss -o src/ --watch --recursive",
- "start": "react-scripts start",
- "build": "react-scripts build",
+ "start-js": "react-scripts start",
Expand Down