Make sure log_scale parameter has lower bound > 0 during model expansion #4463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@sunnyshen321 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85299292. |
sunnyshen321
pushed a commit
to sunnyshen321/Ax
that referenced
this pull request
Oct 23, 2025
…ion (facebook#4463) Summary: User may have OOD prod arm where a certain param value is 0 while they want to tune the parameter with values > 0 in log scale, and if that's the case model expansion will include 0 in the model space (https://fburl.com/code/hvwpnaax) We should add a check to make sure the expanded lower bounds are always positive for log scale RangeParameter Differential Revision: D85299292
sunnyshen321
force-pushed
the
export-D85299292
branch
from
851fe31 to
2ac7bd3
Compare
…ion (facebook#4463) Summary: User may have OOD prod arm where a certain param value is 0 while they want to tune the parameter with values > 0 in log scale, and if that's the case model expansion will include 0 in the model space (https://fburl.com/code/hvwpnaax) We should add a check to make sure the expanded lower bounds are always positive for log scale RangeParameter Reviewed By: Balandat Differential Revision: D85299292
sunnyshen321
force-pushed
the
export-D85299292
branch
from
2ac7bd3 to
3f384a7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4463 +/- ##
==========================================
- Coverage 96.59% 96.58% -0.01%
==========================================
Files 549 549
Lines 56623 56641 +18
==========================================
+ Hits 54693 54708 +15
- Misses 1930 1933 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 7c4f2f1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
User may have OOD prod arm where a certain param value is 0 while they want to tune the parameter with values > 0 in log scale, and if that's the case model expansion will include 0 in the model space (https://fburl.com/code/hvwpnaax)
We should add a check to make sure the expanded lower bounds are always positive for log scale RangeParameter
Differential Revision: D85299292