Treat early-stopped trials as pending #4450
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ## Context We encounter duplicates in candidate generation when using an early-stopping strategy. So far this has been mitigated by specifying `should_deduplicate=True` in the `GenerationNode`. This appears to stem from an early-stopping trial f(x, t) stopped at progression t < T later being deemed promising by the surrogate when extrapolated to f(x, T) with fixed features. ## Changes This adds early-stopped trials to the pending observation features, which serves to prevent it from being suggested later. TODO: Benchmarking Differential Revision: D84842619
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4450 +/- ##
=======================================
Coverage 96.19% 96.19%
=======================================
Files 553 553
Lines 56687 56687
=======================================
Hits 54531 54531
Misses 2156 2156 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
We encounter duplicates in candidate generation when using an early-stopping strategy. So far this has been mitigated by specifying
should_deduplicate=Truein theGenerationNode. This appears to stem from an early-stopping trial f(x, t) stopped at progression t < T later being deemed promising by the surrogate when extrapolated to f(x, T) with fixed features.Changes
This adds early-stopped trials to the pending observation features, which serves to prevent it from being suggested later.
TODO: Benchmarking
Differential Revision: D84842619