Skip to content

Conversation

@saitcakmak
Copy link
Contributor

Summary:
Removes a bunch of model fitting & acqf construction utils that were used in legacy generators. These are not used anywhere since the legacy generator has been removed.

Also removed botorch_moo_defaults to botorch_moo_utils to better communicate its purpose.

Reviewed By: dme65

Differential Revision: D84653561

Summary:
Removes a bunch of model fitting & acqf construction utils that were used in legacy generators. These are not used anywhere since the legacy generator has been removed.

Also removed `botorch_moo_defaults` to `botorch_moo_utils` to better communicate its purpose.

Reviewed By: dme65

Differential Revision: D84653561
@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 14, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 14, 2025

@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84653561.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 99.01961% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.21%. Comparing base (4f4071f) to head (48841de).

Files with missing lines Patch % Lines
ax/generators/torch/botorch_moo_utils.py 98.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4430      +/-   ##
==========================================
+ Coverage   96.16%   96.21%   +0.04%     
==========================================
  Files         555      553       -2     
  Lines       57269    56745     -524     
==========================================
- Hits        55071    54595     -476     
+ Misses       2198     2150      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants