Raise errors for unsupported hierarchical search space functionalities #4374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
kayween
added a commit
to kayween/Ax
that referenced
this pull request
Oct 1, 2025
facebook#4374) Summary: Raise errors for unsupported HSS functionalities. Differential Revision: D83626637
kayween
force-pushed
the
export-D83626637
branch
from
6a73005 to
90176a0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4374 +/- ##
==========================================
- Coverage 96.26% 96.26% -0.01%
==========================================
Files 564 564
Lines 58084 58098 +14
==========================================
+ Hits 55915 55928 +13
- Misses 2169 2170 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kayween
force-pushed
the
export-D83626637
branch
from
90176a0 to
129ecaf
Compare
kayween
added a commit
to kayween/Ax
that referenced
this pull request
Oct 2, 2025
facebook#4374) Summary: Raise errors for unsupported HSS functionalities. Differential Revision: D83626637
facebook#4374) Summary: Raise errors for unsupported HSS functionalities. Those functionalities require long-term planning. So the main motivation here is to fail them explicitly as opposed to let things fail silently, which might lead to sneaky bugs. 1. Error out when a hierarchical choice parameter has >= 3 different values - Hierarchical parameters with >= 3 values will become float-valued after normalization. But the upstream BoTorch models do not support float-valued hierarchical parameters yet. - `OneHot` does not support hierarchical parameters yet. But unordered hierarchical choice parameters (which necessarily has >= 3 values) will go through `OneHot`. 1. Error out when there is a float-valued hierarchical parameters, because they are currently skipped by `ChoiceToNumericalChoice`. Differential Revision: D83626637
kayween
force-pushed
the
export-D83626637
branch
from
129ecaf to
c5dd49c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Raise errors for unsupported HSS functionalities.
Differential Revision: D83626637