Allow SQAArm.generator_run_id to be nullable
#4363
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating diff in D83488268. |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Sep 29, 2025
Summary: **Goal of this stack: attach all arms on the experiment, to the experiment object itself, as the main "ground truth" for them.** Differential Revision: D83488268
lena-kashtelyan
force-pushed
the
export-D83488268
branch
from
9081919 to
ac4241c
Compare
|
@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating diff in D83488268. |
Summary: **Goal of this stack: attach all arms on the experiment, to the experiment object itself, as the main "ground truth" for them.** Differential Revision: D83488268
lena-kashtelyan
force-pushed
the
export-D83488268
branch
from
ac4241c to
d19aa5a
Compare
|
@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83488268. |
1 similar comment
|
@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83488268. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4363 +/- ##
=======================================
Coverage 96.25% 96.26%
=======================================
Files 564 564
Lines 58056 58056
=======================================
+ Hits 55884 55886 +2
+ Misses 2172 2170 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Goal of this stack: attach all arms on the experiment, to the experiment object itself, as the main "ground truth" for them.
Differential Revision: D83488268