Make model based Derelativize.transform_optimization_config no-op if a fitted model is not yet available #4246
+63
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a fitted model is not yet available Summary: In order to use model predicted status quo values, we first need to have a fitted model. This prevents transforming optimization config in `Adapter._transform_data` and using it when instantiating the subsequent transforms, which we want to do to avoid the need to separately derelativize the opt config in transforms like `Winsorize` & `BilogY` (WIP D81597506). This diff changes the behavior of `Derelativize.transform_optimization_config` to be no-op rather than error out when a fitted model is not yet available. This will leave the `optimization_config` unchanged in `Adapter._transform_data` and untransform it using the model predictions in `Adapter.gen`. Reviewed By: dme65 Differential Revision: D81624306
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D81624306 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4246 +/- ##
=======================================
Coverage 96.12% 96.13%
=======================================
Files 566 566
Lines 57639 57658 +19
=======================================
+ Hits 55408 55427 +19
Misses 2231 2231 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
abandoned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In order to use model predicted status quo values, we first need to have a fitted model. This prevents transforming optimization config in
Adapter._transform_dataand using it when instantiating the subsequent transforms, which we want to do to avoid the need to separately derelativize the opt config in transforms likeWinsorize&BilogY(WIP D81597506).This diff changes the behavior of
Derelativize.transform_optimization_configto be no-op rather than error out when a fitted model is not yet available. This will leave theoptimization_configunchanged inAdapter._transform_dataand untransform it using the model predictions inAdapter.gen.Reviewed By: dme65
Differential Revision: D81624306