Soft-deprecate combine_with_last_data arg, setting it as not overwrite_existing_data
#4211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75696517 |
bernardbeckerman
force-pushed
the
export-D75696517
branch
2 times, most recently
from
d244a83 to
bad7154
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75696517 |
bernardbeckerman
force-pushed
the
export-D75696517
branch
from
bad7154 to
7e4b511
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75696517 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D75696517 |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Aug 27, 2025
…te_existing_data` (facebook#4211) Summary: Pull Request resolved: facebook#4211 Diff contents: * Soft-deprecates `combine_with_last_data` arg in `Experiment.attach_data` signature, docs, and logic. * For all passthrough callsites, updates signature and docs. * Removes all direct specification of `combine_with_last_data=True/False`, ensuring that the same behavior remains after the change (i.e., `overwrite_existing_data is not combine_with_last_data`). Reviewed By: saitcakmak Differential Revision: D75696517
bernardbeckerman
force-pushed
the
export-D75696517
branch
from
7e4b511 to
526e8b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75696517 |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Aug 27, 2025
…te_existing_data` (facebook#4211) Summary: Diff contents: * Soft-deprecates `combine_with_last_data` arg in `Experiment.attach_data` signature, docs, and logic. * For all passthrough callsites, updates signature and docs. * Removes all direct specification of `combine_with_last_data=True/False`, ensuring that the same behavior remains after the change (i.e., `overwrite_existing_data is not combine_with_last_data`). Reviewed By: saitcakmak Differential Revision: D75696517
bernardbeckerman
force-pushed
the
export-D75696517
branch
from
526e8b2 to
a6ed52f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75696517 |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Aug 27, 2025
…te_existing_data` (facebook#4211) Summary: Pull Request resolved: facebook#4211 Diff contents: * Soft-deprecates `combine_with_last_data` arg in `Experiment.attach_data` signature, docs, and logic. * For all passthrough callsites, updates signature and docs. * Removes all direct specification of `combine_with_last_data=True/False`, ensuring that the same behavior remains after the change (i.e., `overwrite_existing_data is not combine_with_last_data`). Reviewed By: saitcakmak Differential Revision: D75696517
bernardbeckerman
force-pushed
the
export-D75696517
branch
from
a6ed52f to
002ad1c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75696517 |
…te_existing_data` (facebook#4211) Summary: Diff contents: * Soft-deprecates `combine_with_last_data` arg in `Experiment.attach_data` signature, docs, and logic. * For all passthrough callsites, updates signature and docs. * Removes all direct specification of `combine_with_last_data=True/False`, ensuring that the same behavior remains after the change (i.e., `overwrite_existing_data is not combine_with_last_data`). Reviewed By: saitcakmak Differential Revision: D75696517
bernardbeckerman
force-pushed
the
export-D75696517
branch
from
002ad1c to
36deb7c
Compare
|
@bernardbeckerman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D75696517. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Diff contents:
combine_with_last_dataarg inExperiment.attach_datasignature, docs, and logic.combine_with_last_data=True/False, ensuring that the same behavior remains after the change (i.e.,overwrite_existing_data is not combine_with_last_data).Reviewed By: saitcakmak
Differential Revision: D75696517