Skip to content

Conversation

@lena-kashtelyan
Copy link
Contributor

Summary:
Still figuring out if this is entirely safe, but I think we can lose most of our internal-only SQA classes, because they were meant to accommodate analysis run and scheduler, which we no longer have (now that we deprecated legacy PTS)! Woohoo!

Curious what folks think : )

Differential Revision: D80175881

@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 25, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80175881

@facebook-github-bot
Copy link
Contributor

@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating diff in D80175881.

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.29%. Comparing base (2336bb6) to head (3c8e20d).

Files with missing lines Patch % Lines
ax/storage/sqa_store/encoder.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4200   +/-   ##
=======================================
  Coverage   96.28%   96.29%           
=======================================
  Files         568      568           
  Lines       57922    57926    +4     
=======================================
+ Hits        55772    55780    +8     
+ Misses       2150     2146    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lena-kashtelyan pushed a commit to lena-kashtelyan/Ax that referenced this pull request Sep 17, 2025
…ped) (facebook#4200)

Summary: Pull Request resolved: facebook#4200

Differential Revision: D80175881
@facebook-github-bot
Copy link
Contributor

@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating diff in D80175881.

lena-kashtelyan pushed a commit to lena-kashtelyan/Ax that referenced this pull request Sep 17, 2025
…ped) (facebook#4200)

Summary: Pull Request resolved: facebook#4200

Differential Revision: D80175881
…ped) (facebook#4200)

Summary: Pull Request resolved: facebook#4200

Differential Revision: D80175881
@facebook-github-bot
Copy link
Contributor

@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating diff in D80175881.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6f0df4a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants