-
Notifications
You must be signed in to change notification settings - Fork 349
Deprecate nearly all internal SQA classes (now that legacy PTS is reaped) #4200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D80175881 |
16989e0 to
ae79388
Compare
|
@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating diff in D80175881. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4200 +/- ##
=======================================
Coverage 96.28% 96.29%
=======================================
Files 568 568
Lines 57922 57926 +4
=======================================
+ Hits 55772 55780 +8
+ Misses 2150 2146 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ped) (facebook#4200) Summary: Pull Request resolved: facebook#4200 Differential Revision: D80175881
ae79388 to
a505e8f
Compare
|
@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating diff in D80175881. |
…ped) (facebook#4200) Summary: Pull Request resolved: facebook#4200 Differential Revision: D80175881
…ped) (facebook#4200) Summary: Pull Request resolved: facebook#4200 Differential Revision: D80175881
a505e8f to
3c8e20d
Compare
|
@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating diff in D80175881. |
|
This pull request has been merged in 6f0df4a. |
Summary:
Still figuring out if this is entirely safe, but I think we can lose most of our internal-only SQA classes, because they were meant to accommodate analysis run and scheduler, which we no longer have (now that we deprecated legacy PTS)! Woohoo!
Curious what folks think : )
Differential Revision: D80175881