Fix pyre errors in experiment.py #4179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D80579073 |
Cesar-Cardoso
added a commit
to Cesar-Cardoso/Ax
that referenced
this pull request
Aug 20, 2025
Summary: Fix remaining Pyre errors in experiment.py Reviewed By: mpolson64 Differential Revision: D80579073
Cesar-Cardoso
force-pushed
the
export-D80579073
branch
from
7f4e685 to
510b0b4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80579073 |
Cesar-Cardoso
added a commit
to Cesar-Cardoso/Ax
that referenced
this pull request
Aug 20, 2025
Summary: Pull Request resolved: facebook#4179 Fix remaining Pyre errors in experiment.py Reviewed By: mpolson64 Differential Revision: D80579073
Cesar-Cardoso
force-pushed
the
export-D80579073
branch
from
510b0b4 to
7ebdd57
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4179 +/- ##
========================================
Coverage 96.26% 96.26%
========================================
Files 564 564
Lines 57917 58099 +182
========================================
+ Hits 55751 55927 +176
- Misses 2166 2172 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cesar-Cardoso
force-pushed
the
export-D80579073
branch
from
7ebdd57 to
272a94e
Compare
Cesar-Cardoso
added a commit
to Cesar-Cardoso/Ax
that referenced
this pull request
Aug 21, 2025
Summary: Fix remaining Pyre errors in experiment.py Reviewed By: mpolson64, lena-kashtelyan Differential Revision: D80579073
|
This pull request was exported from Phabricator. Differential Revision: D80579073 |
Cesar-Cardoso
force-pushed
the
export-D80579073
branch
from
272a94e to
1d36c72
Compare
Cesar-Cardoso
added a commit
to Cesar-Cardoso/Ax
that referenced
this pull request
Aug 21, 2025
Summary: Pull Request resolved: facebook#4179 Fix remaining Pyre errors in experiment.py Reviewed By: mpolson64, lena-kashtelyan Differential Revision: D80579073
Cesar-Cardoso
force-pushed
the
export-D80579073
branch
from
1d36c72 to
4cdce76
Compare
Cesar-Cardoso
added a commit
to Cesar-Cardoso/Ax
that referenced
this pull request
Aug 29, 2025
Summary: Fix remaining Pyre errors in experiment.py Reviewed By: mpolson64, lena-kashtelyan Differential Revision: D80579073
|
This pull request was exported from Phabricator. Differential Revision: D80579073 |
Cesar-Cardoso
force-pushed
the
export-D80579073
branch
from
4cdce76 to
9e5fd0c
Compare
Cesar-Cardoso
added a commit
to Cesar-Cardoso/Ax
that referenced
this pull request
Sep 23, 2025
Summary: Fix remaining Pyre errors in experiment.py Reviewed By: mpolson64, lena-kashtelyan Differential Revision: D80579073
|
@Cesar-Cardoso has exported this pull request. If you are a Meta employee, you can view the originating diff in D80579073. |
Cesar-Cardoso
added a commit
to Cesar-Cardoso/Ax
that referenced
this pull request
Sep 23, 2025
Summary: Fix remaining Pyre errors in experiment.py Reviewed By: mpolson64, lena-kashtelyan Differential Revision: D80579073
Cesar-Cardoso
added a commit
to Cesar-Cardoso/Ax
that referenced
this pull request
Sep 24, 2025
Summary: Fix remaining Pyre errors in experiment.py Reviewed By: mpolson64, lena-kashtelyan Differential Revision: D80579073
Cesar-Cardoso
force-pushed
the
export-D80579073
branch
from
9e5fd0c to
29e58fe
Compare
|
@Cesar-Cardoso has exported this pull request. If you are a Meta employee, you can view the originating diff in D80579073. |
Cesar-Cardoso
added a commit
to Cesar-Cardoso/Ax
that referenced
this pull request
Sep 24, 2025
Summary: Fix remaining Pyre errors in experiment.py Reviewed By: mpolson64, lena-kashtelyan Differential Revision: D80579073
Summary: Add two properties to `Parameter`: 1. `backfill_value` - used for parameters added to experiments that already have run trials. Specifies the backfill value to use for trials that have already run. 2. `default_value` - used for parameters disabled in experiments that already have run trials. Specified the default value to use in modeling for future trials. Reviewed By: lena-kashtelyan Differential Revision: D79260975
Summary: In `Experiment` add two methods `add_parameters_to_search_space` and `disable_parameters_in_search_space`. In `Adapter._process_and_transform_data` check if the experiment's search space has been updated and update the adapter's search space and model space. Use `backfill_values` for `FillMissingParameters` transform. In `GenerationNode._determine_fixed_features_from_node` check for any disabled parameters. Add their `default_value` as fixed features. Reviewed By: lena-kashtelyan Differential Revision: D79263457
Summary: Fix remaining Pyre errors in experiment.py Reviewed By: mpolson64, lena-kashtelyan Differential Revision: D80579073
Cesar-Cardoso
force-pushed
the
export-D80579073
branch
from
29e58fe to
85d5cfb
Compare
|
@Cesar-Cardoso has exported this pull request. If you are a Meta employee, you can view the originating diff in D80579073. |
|
This pull request has been merged in f20f3de. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix remaining Pyre errors in experiment.py
Differential Revision: D80579073